From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EBDA171CD; Sun, 5 Jul 2026 23:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783294883; cv=none; b=TTv0q4/QlDXRhxch2RN9iCRtFql1Hxaat9GL4VmuTb4cdWnYkpyppvURzQkmZlEg4glVta0oGO52AiWDfi01s6dV8BfK+okREykWRaE7SmWWN+Fr0x9uHj17lxT9DGx9X0IJR3RL1qvsY96cbStP30UkxCaC/Jnu045r/5AXNNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783294883; c=relaxed/simple; bh=j4UHXdIKS1X4jO8pcuQ4Vnfg6JT1EnD/XaqMHlRkFGg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WhpjuOGO1MuH5T9G01j+t1qQIBQtUuV5cCmNJTzznK1EKfhpgkK87IPBRbqUx8fPJ8nEQrr4hyqrNI1gMl+UbBrwQYNxrncz3G8FRzvVYC8JCTV4Ll0FGqx9nkunS+9U6lH95h94lM6Jw/SYIMvbk4vn4G5mvB+DbjKb+Uc4q/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=g/LufPGP; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="g/LufPGP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C2B01F000E9; Sun, 5 Jul 2026 23:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783294882; bh=lBr6LGeQEfi/gguF0uhUwTMBWbLqEubQbfsnGeA9+84=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=g/LufPGPrUTVjTHlUExUH+F0fz3BmbIVIFO5ClRj7004Zc6X+9uBcZcVoeD8bRuNy C0irRqSX0mCOxQdIhuKrEeGjqaEzmIWFB3hGQjxSvz/FWEJRb0mZLN/ldUHJV1srSc 5iFL+KzHQBZL8A5J6LcF7bMuplf9fSlUfRsVP+A3kvUJYrbqIQ8dv5kCKwZh73/PSM byIGWdGNPIy6dwJ91EYr7BqG3NTactYUA+m19U/XzKjPXxgxF4z3cW3diJNefUiEU+ WmpfAWwZsZrtir6FXIRjj5OwHB1pUdUnopxA+3flW6fBlaHZpUobTCR5055n3FX/LG wHAarbj+OXFwQ== Date: Mon, 6 Jul 2026 00:41:14 +0100 From: Jonathan Cameron To: Jishnu Prakash Cc: David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Kamal Wadhwa , David Collins , Anjelique Melendez , Neil Armstrong , Stephan Gerhold Subject: Re: [PATCH v3 2/3] iio: adc: qcom-spmi-adc5-gen3: Remove an unnecessary print Message-ID: <20260706004114.5bf9d5ba@jic23-huawei> In-Reply-To: <20260705-gen3_adc_tm-v3-2-ac62f387dbce@oss.qualcomm.com> References: <20260705-gen3_adc_tm-v3-0-ac62f387dbce@oss.qualcomm.com> <20260705-gen3_adc_tm-v3-2-ac62f387dbce@oss.qualcomm.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 05 Jul 2026 22:23:34 +0530 Jishnu Prakash wrote: > devm_request_threaded_irq internally prints an error message using > dev_err_probe in case of any errors. Remove the error print in the > devm_request_threaded_irq failure path as it is not needed. > > Signed-off-by: Jishnu Prakash On basis I might not be taking this through IIO. Reviewed-by: Jonathan Cameron > --- > drivers/iio/adc/qcom-spmi-adc5-gen3.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/qcom-spmi-adc5-gen3.c b/drivers/iio/adc/qcom-spmi-adc5-gen3.c > index c1962312afcd..74988040e6e5 100644 > --- a/drivers/iio/adc/qcom-spmi-adc5-gen3.c > +++ b/drivers/iio/adc/qcom-spmi-adc5-gen3.c > @@ -793,9 +793,7 @@ static int adc5_gen3_probe(struct platform_device *pdev) > adc->dev_data.base[ADC5_GEN3_VADC_SDAM].irq_name, > adc); > if (ret) > - return dev_err_probe(dev, ret, > - "Failed to request SDAM%d irq\n", > - ADC5_GEN3_VADC_SDAM); > + return ret; > > ret = adc5_get_fw_data(adc); > if (ret) >