From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: David Lechner <dlechner@baylibre.com>,
Paul Geurts <paul.geurts@prodrive-technologies.com>,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, tobias.sperling@softing.com
Subject: Re: [PATCH v4] iio: ti-ads7138: Disable STATS_EN bit while reading conversion results
Date: Sun, 12 Jul 2026 00:14:14 +0100 [thread overview]
Message-ID: <20260712001414.70a87eec@jic23-huawei> (raw)
In-Reply-To: <akwI7bzJUZasGbq-@ashevche-desk.local>
On Mon, 6 Jul 2026 22:58:37 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Mon, Jul 06, 2026 at 11:30:59AM -0500, David Lechner wrote:
> > On 7/6/26 2:48 AM, Paul Geurts wrote:
>
> ...
>
> > IIO style is to have /* on separate line for multi-line comments.
> >
> > > + /* Reading the statistics registers reinitializes them. This is unfortunate
> > > + * but necessary to prevent data races
> > > + */
>
> Also multiline comments should follow English grammar and punctuation, in
> particular the sentences should have a period at the end.
>
Tweaked all the stuff mentioned and a few other bits in commit message.
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
prev parent reply other threads:[~2026-07-11 23:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 7:48 [PATCH v4] iio: ti-ads7138: Disable STATS_EN bit while reading conversion results Paul Geurts
2026-07-06 16:30 ` David Lechner
2026-07-06 19:58 ` Andy Shevchenko
2026-07-11 23:14 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260712001414.70a87eec@jic23-huawei \
--to=jonathan.cameron@oss.qualcomm.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=paul.geurts@prodrive-technologies.com \
--cc=tobias.sperling@softing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox