From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Pan Chuang <panchuang@vivo.com>
Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
William Breathitt Gray <wbg@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Julien Panis <jpanis@baylibre.com>,
David Lechner <david@lechnology.com>,
linux-iio@vger.kernel.org (open list:COUNTER SUBSYSTEM),
linux-stm32@st-md-mailman.stormreply.com (moderated
list:ARM/STM32 ARCHITECTURE),
linux-arm-kernel@lists.infradead.org (moderated list:ARM/STM32
ARCHITECTURE), linux-kernel@vger.kernel.org (open list),
linux-omap@vger.kernel.org (open list:TI ENHANCED CAPTURE (eCAP)
DRIVER)
Subject: Re: [PATCH] counter: Remove redundant dev_err()/dev_err_probe()
Date: Mon, 13 Jul 2026 16:12:15 +0200 [thread overview]
Message-ID: <20260713161215.00001cc3@gmail.com> (raw)
In-Reply-To: <20260713131005.306069-1-panchuang@vivo.com>
On Mon, 13 Jul 2026 21:10:04 +0800
Pan Chuang <panchuang@vivo.com> wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq()
> automatically log detailed error messages on failure. Remove the
> now-redundant driver-specific dev_err() and dev_err_probe() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
I think you can drop the commit hash and title from the message.
Otherwise LGTM.
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards
CJD
next prev parent reply other threads:[~2026-07-13 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 13:10 [PATCH] counter: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-13 14:12 ` Joshua Crofts [this message]
2026-07-13 14:20 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713161215.00001cc3@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=david@lechnology.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=jpanis@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=panchuang@vivo.com \
--cc=vigneshr@ti.com \
--cc=wbg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox