From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Vojtěch Krátký" <vo.kratky@seznam.cz>,
nuno.sa@analog.com, Michael.Hennerich@analog.com,
dlechner@baylibre.com, andy@kernel.org, linux@analog.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: resolver: ad2s1200: use dev_err_probe()
Date: Sat, 18 Jul 2026 23:50:36 +0100 [thread overview]
Message-ID: <20260718235036.6b71a337@jic23-huawei> (raw)
In-Reply-To: <alkg54Nc79f-bmha@ashevche-desk.local>
On Thu, 16 Jul 2026 21:20:23 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Thu, Jul 16, 2026 at 07:03:06PM +0200, Vojtěch Krátký wrote:
> > Use dev_err_probe() instead of dev_err() to simplify the error path
> > and cleanly handle deferred probing.
>
> Wait at least 24h before sending a new version. Please, read the comments
> I gave against v1.
>
> ...
>
> No need to send a v3, now it's a good time to read comments, discuss, take
> other opinions. For example, if Jonathan is okay with v2, it maybe good to
> go.
I think Andy's suggestion was a good one, but given it would involve a couple
of patches to add it and convert other places it can be used, probably followed
by an update of this patch, I'm going to take this now and suggest anyone who
is interested can revisit Andy's comments.
>
prev parent reply other threads:[~2026-07-18 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 17:03 [PATCH v2] iio: resolver: ad2s1200: use dev_err_probe() Vojtěch Krátký
2026-07-16 18:20 ` Andy Shevchenko
2026-07-18 22:50 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260718235036.6b71a337@jic23-huawei \
--to=jonathan.cameron@oss.qualcomm.com \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
--cc=vo.kratky@seznam.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox