From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32E353D649F; Mon, 20 Jul 2026 09:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784540426; cv=none; b=g167AzA49aIyVDGT5UmQKgDqaAqPxkQfMVUZtn0rrMVa/Ec+VWgYcC/aZeLbs9co2mkcc++Sks919810m1YYyf+3fO6AYr7HUumEBgci1UtSjfDecjE6a1m8w6Mzzhx2gBmlaqT1K5k3wT+kPCfBnSDH6/WourMvIQoUIZBME+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784540426; c=relaxed/simple; bh=RkMRyxbK/IcHIB1V6VQ8y8wKqy1o4F7ywwpz6kytXYU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=a61Z3ZDS3/l4FzUEfYJqBGusa6PRpKAnthpBYLPOjJTfGQ6ByHB71/nU9qj7KmTPd1UCo/nZFHztfRZKMALvyggN6G7iN/1eEEWLVZaxAPSy4Za9wopwlAup3fRB+MAY3KWyusx5xnRgsrCnaHyAHDRJ7JK+2I20pKCLz7z8GFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c305l9/q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c305l9/q" Received: by smtp.kernel.org (Postfix) with ESMTPS id E2F5DC2BD04; Mon, 20 Jul 2026 09:40:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1784540425; bh=RkMRyxbK/IcHIB1V6VQ8y8wKqy1o4F7ywwpz6kytXYU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=c305l9/q2IHEWEL95RyE6O9lNipokpxAY9XgL9FhAysp8qAmX42F7sqwyR+p6nrtd PM4aVwZxgug/IIcm+wDO+/nz97exhBTsReX6AB+wOEGyEtHW4fuyW+y3NU+Ep+UsEd 3RYCpMeZXm9nrMmVZEmOvGyyT7t3ts2rne/KzOay4vsmuUIEcScMxnRqtnUgfcKNWB umioPb/Iz3BkPVMc+dKrrntBdWZwBQZM+IwuIe+MbmoMaTBOZFQVPlXJXEYGq4ux8x jPWkq+iVPwsEedy0YBlMQaBtBDpUrAh0mXQdYUEaRBLob2OgfEuBrbllvJwITRF9hd Dy8QlqRSOFBGQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D13C7C44521; Mon, 20 Jul 2026 09:40:25 +0000 (UTC) From: Sanjay Chitroda via B4 Relay Date: Mon, 20 Jul 2026 15:10:18 +0530 Subject: [PATCH 06/10] iio: magnetometer: hid-sensor-magn-3d: use local struct device Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-hid-iio-local-struct-device-v1-6-74496fee6327@gmail.com> References: <20260720-hid-iio-local-struct-device-v1-0-74496fee6327@gmail.com> In-Reply-To: <20260720-hid-iio-local-struct-device-v1-0-74496fee6327@gmail.com> To: Jiri Kosina , Jonathan Cameron , Srinivas Pandruvada , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Sanjay Chitroda X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784540423; l=5803; i=sanjayembeddedse@gmail.com; s=20260702; h=from:subject:message-id; bh=YcOmzT5cC/xJwy/yQyWOjATzzvkHHHTaevRR0MmJczM=; b=WGETJTQxWY5k5eqWvp33D6N1o+Ng6+pWgbHDfsAWMQAyzfKxjgz27FK7s8jACacy9yT8Ti0/F DyMYsh3X303ApaiTdFuV6Pp55kpdAD7MKG1LozBrEkAhZjsWfws/jcI X-Developer-Key: i=sanjayembeddedse@gmail.com; a=ed25519; pk=PcneEFtkmY+Ldl+KmOTpB/Q/HDsqko6Fb0/Z/5cuycI= X-Endpoint-Received: by B4 Relay for sanjayembeddedse@gmail.com/20260702 with auth_id=848 X-Original-From: Sanjay Chitroda Reply-To: sanjayembeddedse@gmail.com From: Sanjay Chitroda Introduce a local struct device pointer derived from &pdev->dev. This avoids repeated &pdev->dev usage and improves readability. Signed-off-by: Sanjay Chitroda --- drivers/iio/magnetometer/hid-sensor-magn-3d.c | 43 ++++++++++++--------------- 1 file changed, 19 insertions(+), 24 deletions(-) diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c b/drivers/iio/magnetometer/hid-sensor-magn-3d.c index ad18f233ee16..c9077adde882 100644 --- a/drivers/iio/magnetometer/hid-sensor-magn-3d.c +++ b/drivers/iio/magnetometer/hid-sensor-magn-3d.c @@ -337,6 +337,7 @@ static int magn_3d_parse_report(struct platform_device *pdev, u32 usage_id, struct magn_3d_state *st) { + struct device *dev = &pdev->dev; int i; int attr_count = 0; struct iio_chan_spec *_channels; @@ -357,35 +358,30 @@ static int magn_3d_parse_report(struct platform_device *pdev, } if (attr_count <= 0) { - dev_err(&pdev->dev, - "failed to find any supported usage attributes in report\n"); + dev_err(dev, "failed to find any supported usage attributes in report\n"); return -EINVAL; } - dev_dbg(&pdev->dev, "magn_3d Found %d usage attributes\n", attr_count); - dev_dbg(&pdev->dev, "magn_3d X: %x:%x Y: %x:%x Z: %x:%x\n", + dev_dbg(dev, "magn_3d Found %d usage attributes\n", attr_count); + dev_dbg(dev, "magn_3d X: %x:%x Y: %x:%x Z: %x:%x\n", st->magn[0].index, st->magn[0].report_id, st->magn[1].index, st->magn[1].report_id, st->magn[2].index, st->magn[2].report_id); /* Setup IIO channel array */ - _channels = devm_kcalloc(&pdev->dev, attr_count, - sizeof(struct iio_chan_spec), - GFP_KERNEL); + _channels = devm_kcalloc(dev, attr_count, sizeof(struct iio_chan_spec), GFP_KERNEL); if (!_channels) { - dev_err(&pdev->dev, - "failed to allocate space for iio channels\n"); + dev_err(dev, "failed to allocate space for iio channels\n"); return -ENOMEM; } /* attr_count include timestamp channel, and the iio_vals should be aligned to 8byte */ - st->iio_vals = devm_kcalloc(&pdev->dev, + st->iio_vals = devm_kcalloc(dev, ((attr_count + 1) % 2 + (attr_count + 1) / 2) * 2, sizeof(u32), GFP_KERNEL); if (!st->iio_vals) { - dev_err(&pdev->dev, - "failed to allocate space for iio values array\n"); + dev_err(dev, "failed to allocate space for iio values array\n"); return -ENOMEM; } @@ -412,14 +408,13 @@ static int magn_3d_parse_report(struct platform_device *pdev, } if (*chan_count <= 0) { - dev_err(&pdev->dev, - "failed to find any magnetic channels setup\n"); + dev_err(dev, "failed to find any magnetic channels setup\n"); return -EINVAL; } *channels = _channels; - dev_dbg(&pdev->dev, "magn_3d Setup %d IIO channels\n", *chan_count); + dev_dbg(dev, "magn_3d Setup %d IIO channels\n", *chan_count); st->magn_flux_attr.scale_precision = hid_sensor_format_scale( HID_USAGE_SENSOR_COMPASS_3D, @@ -439,7 +434,7 @@ static int magn_3d_parse_report(struct platform_device *pdev, HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS | HID_USAGE_SENSOR_ORIENT_COMP_MAGN_NORTH, &st->rot_attributes.sensitivity); - dev_dbg(&pdev->dev, "Sensitivity index:report %d:%d\n", + dev_dbg(dev, "Sensitivity index:report %d:%d\n", st->rot_attributes.sensitivity.index, st->rot_attributes.sensitivity.report_id); } @@ -450,7 +445,8 @@ static int magn_3d_parse_report(struct platform_device *pdev, /* Function to initialize the processing for usage id */ static int hid_magn_3d_probe(struct platform_device *pdev) { - struct hid_sensor_hub_device *hsdev = dev_get_platdata(&pdev->dev); + struct device *dev = &pdev->dev; + struct hid_sensor_hub_device *hsdev = dev_get_platdata(dev); int ret = 0; static char *name = "magn_3d"; struct iio_dev *indio_dev; @@ -458,8 +454,7 @@ static int hid_magn_3d_probe(struct platform_device *pdev) struct iio_chan_spec *channels; int chan_count = 0; - indio_dev = devm_iio_device_alloc(&pdev->dev, - sizeof(struct magn_3d_state)); + indio_dev = devm_iio_device_alloc(dev, sizeof(struct magn_3d_state)); if (!indio_dev) return -ENOMEM; @@ -475,7 +470,7 @@ static int hid_magn_3d_probe(struct platform_device *pdev) magn_3d_sensitivity_addresses, ARRAY_SIZE(magn_3d_sensitivity_addresses)); if (ret) { - dev_err(&pdev->dev, "failed to setup common attributes\n"); + dev_err(dev, "failed to setup common attributes\n"); return ret; } magn_state->rot_attributes = magn_state->magn_flux_attributes; @@ -486,7 +481,7 @@ static int hid_magn_3d_probe(struct platform_device *pdev) &channels, &chan_count, HID_USAGE_SENSOR_COMPASS_3D, magn_state); if (ret) { - dev_err(&pdev->dev, "failed to parse report\n"); + dev_err(dev, "failed to parse report\n"); return ret; } @@ -501,7 +496,7 @@ static int hid_magn_3d_probe(struct platform_device *pdev) ret = hid_sensor_setup_trigger(indio_dev, name, &magn_state->magn_flux_attributes); if (ret < 0) { - dev_err(&pdev->dev, "trigger setup failed\n"); + dev_err(dev, "trigger setup failed\n"); return ret; } @@ -511,13 +506,13 @@ static int hid_magn_3d_probe(struct platform_device *pdev) ret = sensor_hub_register_callback(hsdev, HID_USAGE_SENSOR_COMPASS_3D, &magn_state->callbacks); if (ret < 0) { - dev_err(&pdev->dev, "callback reg failed\n"); + dev_err(dev, "callback reg failed\n"); goto error_remove_trigger; } ret = iio_device_register(indio_dev); if (ret) { - dev_err(&pdev->dev, "device register failed\n"); + dev_err(dev, "device register failed\n"); goto error_remove_callback; } -- 2.34.1