Re: [PATCH] iio: chemical: atlas-sensor: fix PM reference leak in buffer postenable

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 13 Jul 2026 03:00:46 +0000
Moksh Panicker <mokshpanicker.7@gmail.com> wrote:

> atlas_buffer_postenable() acquires a runtime PM reference with
> pm_runtime_resume_and_get() but returns the result of
> atlas_set_interrupt() directly. If atlas_set_interrupt() fails,
> the runtime PM reference is leaked and the device can never
> autosuspend.
> 
> Add pm_runtime_put_autosuspend() on the error path to balance
> the reference.
> 
> Fixes: 0e4f336f50de ("iio: chemical: atlas-sensor: Balance runtime pm + pm_runtime_resume_and_get()")
> Cc: stable@vger.kernel.org
> Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
Hi,

I've applied this to the fixes-togreg branch of iio.git but Linus has been
pushing back on less critical fixes late in cycle so I might shuffle things
around to queue this for the next merge window instead.

Thanks

Jonathan

> ---
>  drivers/iio/chemical/atlas-sensor.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/chemical/atlas-sensor.c b/drivers/iio/chemical/atlas-sensor.c
> index 0e2edcff63f9..b2c1a598b3a5 100644
> --- a/drivers/iio/chemical/atlas-sensor.c
> +++ b/drivers/iio/chemical/atlas-sensor.c
> @@ -413,7 +413,11 @@ static int atlas_buffer_postenable(struct iio_dev *indio_dev)
>  	if (ret)
>  		return ret;
>  
> -	return atlas_set_interrupt(data, true);
> +	ret = atlas_set_interrupt(data, true);
> +	if (ret)
> +		pm_runtime_put_autosuspend(&data->client->dev);
> +
> +	return ret;
>  }
>  
>  static int atlas_buffer_predisable(struct iio_dev *indio_dev)