Linux IIO development
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Wadim Mueller <wafgo01@gmail.com>
Cc: William Breathitt Gray <wbg@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/3] dt-bindings: counter: add gpio-counter binding
Date: Wed, 22 Jul 2026 10:42:13 -0500	[thread overview]
Message-ID: <20260722154213.GA974454-robh@kernel.org> (raw)
In-Reply-To: <20260714081709.17846-2-wafgo01@gmail.com>

On Tue, Jul 14, 2026 at 10:17:07AM +0200, Wadim Mueller wrote:
> Add a binding for a generic GPIO-based counter. Two GPIOs (signal-a,
> signal-b) drive two Counts; optional index GPIOs load a preset. The
> counter function (quadrature, pulse-direction, increase/decrease) is
> selected at runtime via the counter sysfs interface.
> 
> Signed-off-by: Wadim Mueller <wafgo01@gmail.com>
> ---
> v7:
>   - index-gpios split into seperate index1-gpios/index2-gpios, so
>     Count 2 can have an index line without a dummy entry for Count 1
>   - dropped Conors Ack since the binding changed
> ---
>  .../bindings/counter/gpio-counter.yaml        | 60 +++++++++++++++++++
>  1 file changed, 60 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/counter/gpio-counter.yaml
> 
> diff --git a/Documentation/devicetree/bindings/counter/gpio-counter.yaml b/Documentation/devicetree/bindings/counter/gpio-counter.yaml
> new file mode 100644
> index 000000000000..782cb177ed0b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/counter/gpio-counter.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/counter/gpio-counter.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GPIO-based Counter
> +
> +maintainers:
> +  - Wadim Mueller <wafgo01@gmail.com>
> +
> +description: |
> +  GPIO-based software counter with two Counts:
> +    * Count 1: A + B. Quadrature X1/X2/X4, pulse-direction, inc/dec.
> +    * Count 2: B. Inc / dec.
> +  The function is selected at runtime via the counter sysfs ABI. Each

sysfs is not relevant to bindings.

> +  Count has an optional Index (Z) that loads its preset on rising edge.

I don't have any clue what this h/w is based on *this* patch. Rotary 
encoder was mentioned elsewhere, but this patch needs to stand on its 
own. We already have rotary encoder and GPIO decoder bindings. How is 
this h/w different? The patch needs to answer that.

Rob

  reply	other threads:[~2026-07-22 15:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14  8:17 [PATCH v7 0/3] counter: add GPIO-based counter driver Wadim Mueller
2026-07-14  8:17 ` [PATCH v7 1/3] dt-bindings: counter: add gpio-counter binding Wadim Mueller
2026-07-22 15:42   ` Rob Herring [this message]
2026-07-14  8:17 ` [PATCH v7 2/3] counter: add GPIO-based counter driver Wadim Mueller
2026-07-14 12:20   ` Uwe Kleine-König
2026-07-22 11:49   ` William Breathitt Gray
2026-07-22 16:00     ` William Breathitt Gray
2026-07-14  8:17 ` [PATCH v7 3/3] MAINTAINERS: add entry for GPIO " Wadim Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722154213.GA974454-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wafgo01@gmail.com \
    --cc=wbg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox