From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Adi Nata <adinata.softwareengineer@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, u.kleine-koenig@baylibre.com, email@sirat.me,
krzysztof.kozlowski@oss.qualcomm.com, mazziesaccount@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH] [PATCH] iio: chemical: sgp30: cleanup codestyle warning
Date: Thu, 23 Jul 2026 23:55:42 +0200 [thread overview]
Message-ID: <20260723235542.152a6a25@systembl0wer> (raw)
In-Reply-To: <20260723161851.21722-1-adinata.softwareengineer@gmail.com>
On Fri, 24 Jul 2026 00:18:49 +0800
Adi Nata <adinata.softwareengineer@gmail.com> wrote:
> Reported by checkpatch:
> FILE: drivers/iio/chemical/sgp30.c
> WARNING: Prefer __packed over __attribute__((__packed__))
> +} __attribute__((__packed__));
>
> Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
> ---
Same issues as with your previous patch. Additionally, the
subject contains two [PATCH] tags, perhaps you've used git
format-patch or git send-email incorrectly?
After fixing:
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards,
Joshua Crofts
prev parent reply other threads:[~2026-07-23 21:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 16:18 [PATCH] [PATCH] iio: chemical: sgp30: cleanup codestyle warning Adi Nata
2026-07-23 21:55 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723235542.152a6a25@systembl0wer \
--to=joshua.crofts1@gmail.com \
--cc=adinata.softwareengineer@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=email@sirat.me \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox