From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: jean-baptiste.maneyrol@tdk.com,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] iio: inv_sensors: convert to kernel types
Date: Fri, 24 Jul 2026 01:01:55 +0100 [thread overview]
Message-ID: <20260724010155.4cf3c327@jic23-huawei> (raw)
In-Reply-To: <al4GseUNqFlMMF70@ashevche-desk.local>
On Mon, 20 Jul 2026 14:29:53 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Mon, Jul 20, 2026 at 12:38:32PM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:
>
> > Convert standard types (u)intXX_t to kernel type u/sXX.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> ...
>
> > void inv_sensors_timestamp_apply_odr(struct inv_sensors_timestamp *ts,
> > - uint32_t fifo_period, size_t fifo_nb,
> > + u32 fifo_period, size_t fifo_nb,
> > unsigned int fifo_no)
> > {
> > - int64_t interval;
> > - uint32_t fifo_mult;
> > + s64 interval;
> > + u32 fifo_mult;
>
> It makes sense to also amend the ordering to follow reversed xmas tree.
> (On a glance there are more places, but let Jonathan to tweak if he feels
> so.)
>
I'm feeling lazy so nope, left them alone.
Picked up the series on the testing branch of iio.git.
Thanks,
Jonathan
next prev parent reply other threads:[~2026-07-24 0:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 10:38 [PATCH v2 0/3] iio: common: improve InvenSense sample timestamping Jean-Baptiste Maneyrol via B4 Relay
2026-07-20 10:38 ` [PATCH v2 1/3] iio: inv_sensors: convert to kernel types Jean-Baptiste Maneyrol via B4 Relay
2026-07-20 11:29 ` Andy Shevchenko
2026-07-24 0:01 ` Jonathan Cameron [this message]
2026-07-20 10:38 ` [PATCH v2 2/3] iio: inv_sensors: better timestamp alignment when using watermark Jean-Baptiste Maneyrol via B4 Relay
2026-07-20 11:33 ` Andy Shevchenko
2026-07-20 15:07 ` Jean-Baptiste Maneyrol
2026-07-20 19:31 ` Andy Shevchenko
2026-07-20 10:38 ` [PATCH v2 3/3] iio: inv_sensors: improve period measurement by using a longer delay Jean-Baptiste Maneyrol via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724010155.4cf3c327@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox