Linux IIO development
 help / color / mirror / Atom feed
From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Pan Chuang <panchuang@vivo.com>
Cc: "Puranjay Mohan" <puranjay@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
	"Petre Rodan" <petre.rodan@subdimension.ro>,
	"Dan Robertson" <dan@dlrobertson.com>,
	"Matti Vaittinen" <mazziesaccount@gmail.com>,
	"Gustavo Silva" <gustavograzs@gmail.com>,
	"Maxwell Doose" <m32285159@gmail.com>,
	"Tomasz Duszynski" <tduszyns@gmail.com>,
	"Nishant Malpani" <nish.malpani25@gmail.com>,
	"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
	"Li peiyu" <579lpy@gmail.com>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Alex Lanzano" <lanzano.alex@gmail.com>,
	"Jagath Jog J" <jagathjog1996@gmail.com>,
	"Mikael Gonella-Bolduc" <m.gonella.bolduc@gmail.com>,
	"Subhajit Ghosh" <subhajit.ghosh@tweaklogic.com>,
	"Mudit Sharma" <muditsharma.info@gmail.com>,
	"Kevin Tsai" <ktsai@capellamicro.com>,
	"Linus Walleij" <linusw@kernel.org>,
	"Anshul Dalal" <anshulusr@gmail.com>,
	"Song Qiang" <songqiang1304521@gmail.com>,
	"Andreas Klinger" <ak@it-klinger.de>,
	"Uwe Kleine-König (The Capable Hub)"
	<u.kleine-koenig@baylibre.com>, "Siratul Islam" <email@sirat.me>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
	"Xichao Zhao" <zhao.xichao@vivo.com>,
	"Waqar Hameed" <waqar.hameed@axis.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Marcus Folkesson" <marcus.folkesson@gmail.com>,
	"Miao Li" <limiao@kylinos.cn>,
	"Dixit Parmar" <dixitparmar19@gmail.com>,
	"Andrew Davis" <afd@ti.com>, "Kurt Borja" <kuurtb@gmail.com>,
	"Shrikant Raskar" <raskar.shree97@gmail.com>,
	"Chu Guangqing" <chuguangqing@inspur.com>,
	"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"Rafael G. Dias" <rafael.guimaraes.dias@usp.br>,
	"Svyatoslav Ryhel" <clamor95@gmail.com>,
	"Shi Hao" <i.shihao.999@gmail.com>,
	"Colin Ian King" <colin.i.king@gmail.com>,
	"Salah Triki" <salah.triki@gmail.com>,
	"Yury Norov" <ynorov@nvidia.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Yash Suthar" <yashsuthar983@gmail.com>,
	"Achim Gratz" <Achim.Gratz@Stromeko.DE>,
	"Yasin Lee" <yasin.lee.x@gmail.com>,
	linux-iio@vger.kernel.org (open list:ADXL355 THREE-AXIS DIGITAL
	ACCELEROMETER DRIVER),
	linux@analog.com (open list:ANALOG DEVICES INC IIO DRIVERS),
	linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH v2 00/13] iio: Remove redundant error messages on IRQ request failure
Date: Fri, 24 Jul 2026 12:27:01 +0200	[thread overview]
Message-ID: <20260724122701.0000156f@gmail.com> (raw)
In-Reply-To: <20260724030524.607185-1-panchuang@vivo.com>

On Fri, 24 Jul 2026 11:03:35 +0800
Pan Chuang <panchuang@vivo.com> wrote:

> Commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()")
> added automatic error logging to devm_request_threaded_irq() and
> devm_request_any_context_irq() via the new devm_request_result() helper,
> which prints device name, IRQ number, handler functions, and error code
> on failure.
> 
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this
> automatic logging.
> 
> Remove the now-redundant dev_err() and dev_err_probe() calls
> in iio drivers that follow these devm_request_*_irq()
> functions, as the core now provides more detailed diagnostic
> information on failure.
> 
> v2:
> - Rewrap commit description to one line.
> - Drop redundant "!= 0" and "< 0" comparisons.
> 

Okay, code-wise it's fine, but rewrap your commit messages to 72
characters per line. Feel free to apply my tag for the whole series:

Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

Also, I was scratching my head at how enormous the To: list is, given
these changes are only in IIO, but I assume you also added emails of
the people who authored the latest changes on a file that get_maintainer
outputs - there is no need to do this. Tools like b4 can automatically
add (correct) recipients based on get_maintainer.pl

-- 
Kind regards,
Joshua Crofts

      parent reply	other threads:[~2026-07-24 10:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24  3:03 [PATCH v2 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-24  3:03 ` [PATCH v2 01/13] iio: accel: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-24  3:03 ` [PATCH v2 02/13] iio: addac: ad74413r: Remove redundant dev_err_probe() Pan Chuang
2026-07-24  3:03 ` [PATCH v2 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-24  3:03 ` [PATCH v2 04/13] iio: st_sensors: Remove redundant dev_err() Pan Chuang
2026-07-24  3:03 ` [PATCH v2 05/13] iio: gyro: adxrs290: Remove redundant dev_err_probe() Pan Chuang
2026-07-24  3:03 ` [PATCH v2 06/13] iio: health: Remove redundant dev_err() Pan Chuang
2026-07-24  3:03 ` [PATCH v2 07/13] iio: humidity: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-24  3:03 ` [PATCH v2 08/13] iio: imu: " Pan Chuang
2026-07-24  3:03 ` [PATCH v2 09/13] iio: magnetometer: Remove redundant dev_err() Pan Chuang
2026-07-24  3:03 ` [PATCH v2 10/13] iio: pressure: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-24  3:03 ` [PATCH v2 11/13] iio: proximity: " Pan Chuang
2026-07-24  3:03 ` [PATCH v2 12/13] iio: light: " Pan Chuang
2026-07-24  3:03 ` [PATCH v2 13/13] iio: temperature: " Pan Chuang
2026-07-24 10:27 ` Joshua Crofts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260724122701.0000156f@gmail.com \
    --to=joshua.crofts1@gmail.com \
    --cc=579lpy@gmail.com \
    --cc=Achim.Gratz@Stromeko.DE \
    --cc=Michael.Hennerich@analog.com \
    --cc=afd@ti.com \
    --cc=ak@it-klinger.de \
    --cc=andy@kernel.org \
    --cc=anshulusr@gmail.com \
    --cc=antoniu.miclaus@analog.com \
    --cc=bhelgaas@google.com \
    --cc=bigeasy@linutronix.de \
    --cc=chuguangqing@inspur.com \
    --cc=clamor95@gmail.com \
    --cc=colin.i.king@gmail.com \
    --cc=dakr@kernel.org \
    --cc=dan@dlrobertson.com \
    --cc=dixitparmar19@gmail.com \
    --cc=dlechner@baylibre.com \
    --cc=email@sirat.me \
    --cc=gregkh@linuxfoundation.org \
    --cc=gustavograzs@gmail.com \
    --cc=i.shihao.999@gmail.com \
    --cc=jagathjog1996@gmail.com \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=jic23@kernel.org \
    --cc=ktsai@capellamicro.com \
    --cc=kuurtb@gmail.com \
    --cc=lanzano.alex@gmail.com \
    --cc=limiao@kylinos.cn \
    --cc=linusw@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=lorenzo@kernel.org \
    --cc=m.gonella.bolduc@gmail.com \
    --cc=m32285159@gmail.com \
    --cc=marcelo.schmitt@analog.com \
    --cc=marcus.folkesson@gmail.com \
    --cc=mazziesaccount@gmail.com \
    --cc=muditsharma.info@gmail.com \
    --cc=nish.malpani25@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=o-takashi@sakamocchi.jp \
    --cc=panchuang@vivo.com \
    --cc=petre.rodan@subdimension.ro \
    --cc=puranjay@kernel.org \
    --cc=rafael.guimaraes.dias@usp.br \
    --cc=raskar.shree97@gmail.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=salah.triki@gmail.com \
    --cc=songqiang1304521@gmail.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=subhajit.ghosh@tweaklogic.com \
    --cc=tduszyns@gmail.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=waqar.hameed@axis.com \
    --cc=yashsuthar983@gmail.com \
    --cc=yasin.lee.x@gmail.com \
    --cc=ynorov@nvidia.com \
    --cc=zhao.xichao@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox