From: Jonathan Cameron <jic23@kernel.org>
To: "David Lechner (TI)" <dlechner@baylibre.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>, "Chris Hall" <c-hall@ti.com>,
"Patrick Edwards" <pedwards@ti.com>,
"Kurt Borja" <kuurtb@gmail.com>,
"Nguyen Minh Tien" <zizuzacker@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: ti-ads112c14: add support for buffered read
Date: Mon, 27 Jul 2026 02:09:58 +0100 [thread overview]
Message-ID: <20260727020958.4e39fe87@jic23-huawei> (raw)
In-Reply-To: <20260724-iio-adc-ti-ads112c14-buffered-read-v2-2-98b06f3d47d9@baylibre.com>
On Fri, 24 Jul 2026 10:55:07 -0500
"David Lechner (TI)" <dlechner@baylibre.com> wrote:
> Add support for buffered reads using a triggered buffer.
>
> The device has a continuous conversion mode, but that can only be used
> with one channel at a time since there is nothing like a sequencer to
> support that in hardware. Instead, we use single-shot reads like we do
> for direct reads to be able to read multiple channels.
>
> Since CRC is always enabled, buffered reads include the CRC byte along
> with the raw data without verifying it. This allows userspace to perform
> it's own CRC verification per-sample and drop bad samples rather than
> failing the entire buffered read for one bad sample.
>
> Support for continuous conversion mode could be added in the future if
> needed.
>
> Signed-off-by: David Lechner (TI) <dlechner@baylibre.com>
Looks fine to me other than the thing sashiko caught.
J
prev parent reply other threads:[~2026-07-27 1:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 15:55 [PATCH v2 0/2] iio: adc: ti-ads112c14: buffered read support David Lechner (TI)
2026-07-24 15:55 ` [PATCH v2 1/2] iio: adc: ti-ads112c14: add support for I2C CRC8 David Lechner (TI)
2026-07-24 18:33 ` David Lechner
2026-07-27 1:03 ` Jonathan Cameron
2026-07-24 15:55 ` [PATCH v2 2/2] iio: adc: ti-ads112c14: add support for buffered read David Lechner (TI)
2026-07-24 18:34 ` David Lechner
2026-07-27 1:09 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727020958.4e39fe87@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=c-hall@ti.com \
--cc=dlechner@baylibre.com \
--cc=kuurtb@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pedwards@ti.com \
--cc=zizuzacker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox