From: Jonathan Cameron <jic23@kernel.org>
To: "David Lechner (TI)" <dlechner@baylibre.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>, "Chris Hall" <c-hall@ti.com>,
"Patrick Edwards" <pedwards@ti.com>,
"Kurt Borja" <kuurtb@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] iio: adc: ti-ads112c14: add burnout current support
Date: Mon, 27 Jul 2026 03:08:22 +0100 [thread overview]
Message-ID: <20260727030822.3766f628@jic23-huawei> (raw)
In-Reply-To: <20260724-iio-adc-ti-ads112c14-burnout-v1-0-f0204cecbe3a@baylibre.com>
On Fri, 24 Jul 2026 15:49:16 -0500
"David Lechner (TI)" <dlechner@baylibre.com> wrote:
> The TI ADS112C14 ADC has a feature to enable a "burnout" current when
> taking a measurement. This can be used to detect open/short circuit
> conditions of a connected sensor. However, enabling this affects the
> accuracy of the reading. So we add a custom "burnoutraw" attribute for
> this. This works like the standard raw attribute to do a direct read
> but does so with the burnout current enabled.
>
> If this sounds familiar, it is because we discussed this on a similar
> chip recently [1]. And this is why I put the ABI docs in a common ADC
> file rather than one specific to this chip.
>
> [1]: https://lore.kernel.org/linux-iio/20260622110223.7e854dde@jic23-huawei/
>
> Signed-off-by: David Lechner (TI) <dlechner@baylibre.com>
Seems fine to me, but given it is new ABI, I'd like some more eyes on the documentation
patch in particular.
Thanks
Jonathan
> ---
> David Lechner (TI) (2):
> iio: adc: ti-ads112c14: add burnout current support
> iio: ABI: add sysfs attribute for _burnoutraw
>
> Documentation/ABI/testing/sysfs-bus-iio-adc | 9 ++
> drivers/iio/adc/ti-ads112c14.c | 126 ++++++++++++++++++++++++++--
> 2 files changed, 126 insertions(+), 9 deletions(-)
> ---
> base-commit: 0b5e142ced4bcf20532da051934bd694d1bbd470
> change-id: 20260724-iio-adc-ti-ads112c14-burnout-184304669165
> prerequisite-change-id: 20260714-iio-adc-ti-ads112c14-buffered-read-41e5d1ca0dc3:v2
> prerequisite-patch-id: 8723aa599dcf5b836fb81cf1efb6c9096bf60b7a
> prerequisite-patch-id: 12754335ccf210bcdeaa8a5d60b2280618d50993
> prerequisite-change-id: 20260724-iio-adc-ti-ads112c14-continuous-mode-dd1580754609:v1
> prerequisite-patch-id: 8723aa599dcf5b836fb81cf1efb6c9096bf60b7a
> prerequisite-patch-id: 12754335ccf210bcdeaa8a5d60b2280618d50993
> prerequisite-patch-id: ed5d4c1628ef60ed542339fe5fb490383ee8074f
> prerequisite-patch-id: b92f5609fcf39e958e78b4dd74c3d323ebb6a161
>
> Best regards,
> --
> David Lechner (TI) <dlechner@baylibre.com>
>
prev parent reply other threads:[~2026-07-27 2:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 20:49 [PATCH 0/2] iio: adc: ti-ads112c14: add burnout current support David Lechner (TI)
2026-07-24 20:49 ` [PATCH 1/2] " David Lechner (TI)
2026-07-24 20:49 ` [PATCH 2/2] iio: ABI: add sysfs attribute for _burnoutraw David Lechner (TI)
2026-07-27 2:08 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727030822.3766f628@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=c-hall@ti.com \
--cc=dlechner@baylibre.com \
--cc=kuurtb@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pedwards@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox