From: Jonathan Cameron <jic23@kernel.org>
To: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Cc: David Lechner <dlechner@baylibre.com>,
joshua.crofts1@gmail.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Giorgi Tchankvetadze <giorgi@tchankvetadze.com>
Subject: Re: [PATCH] iio: light: veml3328: remove redundant cast in read_avail
Date: Tue, 28 Jul 2026 22:38:48 +0100 [thread overview]
Message-ID: <20260728223848.5736c529@jic23-huawei> (raw)
In-Reply-To: <CAE7dp2qeg=Zzrr+cqOEJOnn7UudiD=a=_578T3OzKCPTX28JmA@mail.gmail.com>
On Mon, 27 Jul 2026 17:50:23 +0400
Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com> wrote:
> On Mon, Jul 27, 2026 at 5:16 PM David Lechner <dlechner@baylibre.com> wrote:
> >
> > Usually, we would declare the array like:
> >
> > static const int veml3328_scale_vals[4][4][2] ...
> >
> > in which case this cast would be needed.
> >
> >
> I intentionally kept the patch tiny and dealt with the obvious thing,
> but yes, I agree this is how it should be done.
I think it is worth making the more complex change to improve the
readability more generally. So if you don't mind, please do that
for v2.
Jonathan
next prev parent reply other threads:[~2026-07-28 21:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 11:27 [PATCH] iio: light: veml3328: remove redundant cast in read_avail Giorgi Tchankvetadze
2026-07-27 13:15 ` David Lechner
2026-07-27 13:50 ` Giorgi Tchankvetadze
2026-07-28 21:38 ` Jonathan Cameron [this message]
2026-07-27 15:28 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728223848.5736c529@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=giorgi@tchankvetadze.com \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox