From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Adi Nata <adinata.softwareengineer@gmail.com>
Cc: lorenzo@kernel.org, jic23@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH] iio: humidity: hts221: Fix checkpatch blank line warning
Date: Sun, 2 Aug 2026 17:38:52 +0200 [thread overview]
Message-ID: <20260802173852.32b4bc52@systembl0wer> (raw)
In-Reply-To: <20260802020614.19732-1-adinata.softwareengineer@gmail.com>
On Sun, 2 Aug 2026 10:06:13 +0800
Adi Nata <adinata.softwareengineer@gmail.com> wrote:
> Checkpatch warning:
>
> WARNING: Missing a blank line after declarations
> + struct hts221_hw *hw = iio_priv(iio_dev);
>
> Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
> ---
This seems like churn on its own, Jonathan may not apply it.
Also, I feel like just putting checkpatch warnings directly into the
commit message is bad practice. Much better if it were "Add a blank line
after variable declarations per checkpatch warning."
--
Kind regards,
Joshua Crofts
next prev parent reply other threads:[~2026-08-02 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-02 2:06 [PATCH] iio: humidity: hts221: Fix checkpatch blank line warning Adi Nata
2026-08-02 15:38 ` Joshua Crofts [this message]
2026-08-02 17:12 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260802173852.32b4bc52@systembl0wer \
--to=joshua.crofts1@gmail.com \
--cc=adinata.softwareengineer@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox