From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: linux-iio@vger.kernel.org, "Jinseob Kim" <kimjinseob88@gmail.com>,
"Sanjay Chitroda" <sanjayembeddedse@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
sashiko-bot@kernel.org,
"Jonathan Cameron" <jonathan.cameron@oss.qualcomm.com>
Subject: Re: [PATCH v2] iio: buffer: Ensure bounce buffer used for unaligned case is zeroed.
Date: Wed, 5 Aug 2026 00:54:12 +0100 [thread overview]
Message-ID: <20260805005412.08c879f4@jic23-huawei> (raw)
In-Reply-To: <20260803112637.000045af@gmail.com>
On Mon, 3 Aug 2026 11:26:37 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> On Mon, 3 Aug 2026 02:22:24 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
>
> > From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
> >
> > iio_push_to_buffers_with_ts_unaligned() leaks uninitialized heap memory
> > to userspace if the data passed in is not a multiple of 8 bytes and the
> > timestamp is enabled. Specify __GFP_ZERO for the devm_krealloc()
> > to ensure any extra space is cleared.
> >
> > Fixes: 95ec3fdf2b79 ("iio: core: Introduce iio_push_to_buffers_with_ts_unaligned()")
> > Reported-by: Sashiko <sashiko-bot@kernel.org>
> > Closes: https://sashiko.dev/#/patchset/20260529121005.1470-1-kimjinseob88%40gmail.com
> > Signed-off-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
> > ---
>
> LGTM, but shouldn't this be a V3 as the previous patch was a V2?
> I got confused for a bit...
Oops. Indeed. Fat fingered.
>
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
>
next prev parent reply other threads:[~2026-08-04 23:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 1:22 [PATCH v2] iio: buffer: Ensure bounce buffer used for unaligned case is zeroed Jonathan Cameron
2026-08-03 9:05 ` Nuno Sá
2026-08-03 9:26 ` Joshua Crofts
2026-08-04 23:54 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-06-04 8:43 Jonathan Cameron
2026-06-04 9:10 ` Andy Shevchenko
2026-06-05 13:50 ` Jonathan Cameron
2026-06-05 19:18 ` Andy Shevchenko
2026-06-08 20:00 ` Nuno Sá
2026-06-14 19:52 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805005412.08c879f4@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jonathan.cameron@oss.qualcomm.com \
--cc=joshua.crofts1@gmail.com \
--cc=kimjinseob88@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sanjayembeddedse@gmail.com \
--cc=sashiko-bot@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox