Linux IIO development
 help / color / mirror / Atom feed
From: Cong Nguyen <congnt264@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] iio: adc: max1363: sign-extend bipolar differential channel reads
Date: Mon, 10 Aug 2026 13:42:34 +0700	[thread overview]
Message-ID: <20260810064234.1850833-1-congnt264@gmail.com> (raw)

The MAX1363 differential channels are bipolar (scan_type.sign = 's') and
the device returns those samples in two's complement. However
max1363_read_single_chan() masks the raw value to the ADC resolution and
stores it as-is, without sign extension. A negative differential reading
is therefore reported to userspace as a large positive value (for a 12-bit
part, -1 reads back as 4095).

These channels expose only IIO_CHAN_INFO_RAW (no offset), so the raw sysfs
value is expected to be the signed result. Sign-extend the masked value
from the resolution bit for differential channels before returning it.
Single-ended channels are unipolar (sign = 'u') and are left unchanged.

Fixes: 168c9d95a940 ("iio:adc:max1363 move from staging.")
Cc: stable@vger.kernel.org
Assisted-by: Claude:claude-opus-4
Signed-off-by: Cong Nguyen <congnt264@gmail.com>
---
 drivers/iio/adc/max1363.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
index 4d0b79cfeb27..497f5daadcea 100644
--- a/drivers/iio/adc/max1363.c
+++ b/drivers/iio/adc/max1363.c
@@ -405,6 +405,14 @@ static int max1363_read_single_chan(struct iio_dev *indio_dev,
 
 		data = rxbuf[0];
 	}
+
+	/*
+	 * Differential channels are bipolar and the device returns the sample
+	 * in two's complement, so sign-extend it from the resolution bit.
+	 */
+	if (chan->differential)
+		data = sign_extend32(data, st->chip_info->bits - 1);
+
 	*val = data;
 
 	return 0;
-- 
2.25.1


             reply	other threads:[~2026-08-10  6:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10  6:42 Cong Nguyen [this message]
2026-08-10  6:45 ` [PATCH] iio: adc: max1363: sign-extend bipolar differential channel reads Andy Shevchenko
2026-08-10 16:50   ` Nguyễn Công

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260810064234.1850833-1-congnt264@gmail.com \
    --to=congnt264@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox