Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Shehryar Ahmad <shehryar.amd@gmail.com>,
	nuno.sa@analog.com, Michael.Hennerich@analog.com,
	dlechner@baylibre.com, andy@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux@analog.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: accel: adi,adis16201: add adis16203 compatible
Date: Wed, 12 Aug 2026 04:35:06 +0100	[thread overview]
Message-ID: <20260812043506.456ced6d@jic23-huawei> (raw)
In-Reply-To: <20260812015421.GA498537-robh@kernel.org>

On Tue, 11 Aug 2026 20:54:21 -0500
Rob Herring <robh@kernel.org> wrote:

> On Wed, Aug 05, 2026 at 03:22:24PM +0500, Shehryar Ahmad wrote:
> > The ADIS16203 has the same external interface as the already
> > documented ADIS16201/ADIS16209, for the properties covered by this
> > binding (compatible/reg, the DIO-based interrupt pin, and VDD
> > supply), verified by datasheets Table 5, Pin Function Descriptions,
> > in the respective Analog Devices datasheets. Some Auxiliary pins
> > differ (e.g. adis16209 marks a few pins DNC where adis16201/adis16203
> > use them as AUX COM), but these are not represented in this binding.
> > Add adis16203 to the existing enum rather than creating a separate
> > file.
> > 
> > Tested with checkpatch.pl --strict and dt_binding_check; both pass
> > with no warnings.  
> 
> This is assumed, no need to record it forever in the commit.
> 
> > Three prior attempts to document this part are visible on the
> > mailing list, all as separate files, each redirected toward this
> > existing binding approach instead: Saalim Quadri, March 2025 [2],
> > and Sheng Kun Chang, April 2026 [3]. See below for Jonathan
> > Cameron's earlier, related attempt [1].

Key thing here is that we generally don't take bindings for drivers
that are in staging and adis16203 remains there.

This patch looks good for when/if the driver is moved out of
staging.  There have been various series on list for that so
perhaps ask those authors what current status is (just reply
to that series).

e.g. 

https://lore.kernel.org/linux-iio/20260401162458.88110-1-nothingchang@mirrorstack.ai/

Which is the parent of the last link below and I think the last of
various attempts to do this.

Jonathan

> > 
> > A richer version adding reset-gpios and a second interrupt
> > (interrupt-names: dio0/dio1) was proposed by Jonathan Cameron in
> > 2023 [1]. I tested the same additions locally for all three
> > parts; checkpatch and dt_binding_check both pass. It is not
> > included here, as it hasn't been verified against any real board
> > dts file, and none in-tree currently reference adis16201,
> > adis16203, or adis16209. Can send that as a follow-up if
> > wanted.
> > 
> > Link: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230129155602.740743-13-jic23@kernel.org/
> > Link: https://lore.kernel.org/all/5390c973-6a92-4de8-b00a-cd62af347ccb@kernel.org/
> > Link: https://lore.kernel.org/all/20260402-fair-wakeful-okapi-3c6dba@quoll/  
> 
> Thanks for the history. It should be after the '---' so it too is not 
> recorded in the commit.
> 
> > 
> > Signed-off-by: Shehryar Ahmad <shehryar.amd@gmail.com>
> > ---
> >  .../devicetree/bindings/iio/accel/adi,adis16201.yaml        | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)  
> 
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>



      reply	other threads:[~2026-08-12  3:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05 10:22 [PATCH] dt-bindings: iio: accel: adi,adis16201: add adis16203 compatible Shehryar Ahmad
2026-08-12  1:54 ` Rob Herring
2026-08-12  3:35   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260812043506.456ced6d@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=shehryar.amd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox