From: Jonathan Cameron <jic23@kernel.org>
To: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
Cc: "Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chris Morgan" <macromorgan@hotmail.com>,
"Luca Weiss" <luca.weiss@fairphone.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] iio: imu: inv_icm42600: sort device id tables numerically
Date: Mon, 17 Aug 2026 03:20:12 +0100 [thread overview]
Message-ID: <20260817032012.779c01af@jic23-huawei> (raw)
In-Reply-To: <20260810191157.125550-2-jorijnvdgraaf@catcrafts.net>
On Mon, 10 Aug 2026 21:11:55 +0200
Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net> wrote:
> The I2C, SPI and OF device id tables list the parts in the chip enum's
> declaration order, which is neither numeric nor alphabetical. Sort the
> entries numerically by part number so new entries have an unambiguous
> position.
>
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
> Link: https://lore.kernel.org/all/20260724012505.02029e51@jic23-huawei/
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
Looks good. I used to pick this sort of thing up ahead of series
but I'm not sure we've figured out how to let Sashiko know that
is the case yet. So I'll leave this for when the reset of the
series is ready to go.
Thanks for tidying this up.
Jonathan
> ---
> No changes in v4.
>
> drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c | 16 ++++++++--------
> drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c | 16 ++++++++--------
> 2 files changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c
> index 28552d2db91d..e44ed6dcde02 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c
> @@ -77,10 +77,10 @@ static const struct i2c_device_id inv_icm42600_id[] = {
> { .name = "icm42600", .driver_data = INV_CHIP_ICM42600 },
> { .name = "icm42602", .driver_data = INV_CHIP_ICM42602 },
> { .name = "icm42605", .driver_data = INV_CHIP_ICM42605 },
> - { .name = "icm42686", .driver_data = INV_CHIP_ICM42686 },
> { .name = "icm42622", .driver_data = INV_CHIP_ICM42622 },
> - { .name = "icm42688", .driver_data = INV_CHIP_ICM42688 },
> { .name = "icm42631", .driver_data = INV_CHIP_ICM42631 },
> + { .name = "icm42686", .driver_data = INV_CHIP_ICM42686 },
> + { .name = "icm42688", .driver_data = INV_CHIP_ICM42688 },
> { }
> };
> MODULE_DEVICE_TABLE(i2c, inv_icm42600_id);
> @@ -95,18 +95,18 @@ static const struct of_device_id inv_icm42600_of_matches[] = {
> }, {
> .compatible = "invensense,icm42605",
> .data = (void *)INV_CHIP_ICM42605,
> - }, {
> - .compatible = "invensense,icm42686",
> - .data = (void *)INV_CHIP_ICM42686,
> }, {
> .compatible = "invensense,icm42622",
> .data = (void *)INV_CHIP_ICM42622,
> - }, {
> - .compatible = "invensense,icm42688",
> - .data = (void *)INV_CHIP_ICM42688,
> }, {
> .compatible = "invensense,icm42631",
> .data = (void *)INV_CHIP_ICM42631,
> + }, {
> + .compatible = "invensense,icm42686",
> + .data = (void *)INV_CHIP_ICM42686,
> + }, {
> + .compatible = "invensense,icm42688",
> + .data = (void *)INV_CHIP_ICM42688,
> },
> { }
> };
> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c
> index faf743bc6444..3e2f4eb42e97 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c
> @@ -74,10 +74,10 @@ static const struct spi_device_id inv_icm42600_id[] = {
> { .name = "icm42600", .driver_data = INV_CHIP_ICM42600 },
> { .name = "icm42602", .driver_data = INV_CHIP_ICM42602 },
> { .name = "icm42605", .driver_data = INV_CHIP_ICM42605 },
> - { .name = "icm42686", .driver_data = INV_CHIP_ICM42686 },
> { .name = "icm42622", .driver_data = INV_CHIP_ICM42622 },
> - { .name = "icm42688", .driver_data = INV_CHIP_ICM42688 },
> { .name = "icm42631", .driver_data = INV_CHIP_ICM42631 },
> + { .name = "icm42686", .driver_data = INV_CHIP_ICM42686 },
> + { .name = "icm42688", .driver_data = INV_CHIP_ICM42688 },
> { }
> };
> MODULE_DEVICE_TABLE(spi, inv_icm42600_id);
> @@ -92,18 +92,18 @@ static const struct of_device_id inv_icm42600_of_matches[] = {
> }, {
> .compatible = "invensense,icm42605",
> .data = (void *)INV_CHIP_ICM42605,
> - }, {
> - .compatible = "invensense,icm42686",
> - .data = (void *)INV_CHIP_ICM42686,
> }, {
> .compatible = "invensense,icm42622",
> .data = (void *)INV_CHIP_ICM42622,
> - }, {
> - .compatible = "invensense,icm42688",
> - .data = (void *)INV_CHIP_ICM42688,
> }, {
> .compatible = "invensense,icm42631",
> .data = (void *)INV_CHIP_ICM42631,
> + }, {
> + .compatible = "invensense,icm42686",
> + .data = (void *)INV_CHIP_ICM42686,
> + }, {
> + .compatible = "invensense,icm42688",
> + .data = (void *)INV_CHIP_ICM42688,
> },
> { }
> };
next prev parent reply other threads:[~2026-08-17 2:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 19:11 [PATCH v4 0/3] iio: imu: inv_icm42600: add support for icm42630 Jorijn van der Graaf
2026-08-10 19:11 ` [PATCH v4 1/3] iio: imu: inv_icm42600: sort device id tables numerically Jorijn van der Graaf
2026-08-17 2:20 ` Jonathan Cameron [this message]
2026-08-10 19:11 ` [PATCH v4 2/3] iio: imu: inv_icm42600: log whoami mismatch instead of failing probe Jorijn van der Graaf
2026-08-10 19:45 ` Andy Shevchenko
2026-08-17 2:18 ` Jonathan Cameron
2026-08-17 8:28 ` Andy Shevchenko
2026-08-10 19:11 ` [PATCH v4 3/3] dt-bindings: iio: imu: icm42600: add icm42630 Jorijn van der Graaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817032012.779c01af@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jorijnvdgraaf@catcrafts.net \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=macromorgan@hotmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox