From: Taha Ed-Dafili <0rayn.dev@gmail.com>
To: andriy.shevchenko@intel.com
Cc: 0rayn.dev@gmail.com, Michael.Hennerich@analog.com,
andy@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
dlechner@baylibre.com, jic23@kernel.org, krzk+dt@kernel.org,
lars@metafoo.de, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@analog.com,
nuno.sa@analog.com, robh@kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH v4 5/6] iio: dac: ad5504: strictly separate ACPI and DT probe paths
Date: Wed, 19 Aug 2026 04:40:45 -0400 [thread overview]
Message-ID: <20260819084045.16300-1-0rayn.dev@gmail.com> (raw)
In-Reply-To: <aoP7Hr3ahJK87tyP@ashevche-desk.local>
> #define AD5504_VA_ACPI_DEFAULT_mV (60 * MILLI)
> What does VA stand for?
VA stands for Analog supply Voltage as far as I know, following Analog
Devices datasheet convention. Will rename to AD5504_VREF_ACPI_DEFAULT_mV
to make it self-explanatory in v5.
> It's better to use has_acpi_companion() or is_acpi_device_node().
> I prefer to see the latter as that one unifies the style of checking
> across the drivers and subsystems.
Will switch to is_acpi_device_node(dev_fwnode(dev)) in v5 and add
<linux/acpi.h> accordingly.
> This should be (MICRO / MILLI) instead of MILLI.
Will fix in v5.
Best Regards,
Taha Ed-Dafili
next prev parent reply other threads:[~2026-08-19 8:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 21:11 [PATCH v4 0/6] iio: dac: ad5504: bindings, cleanups, locking, and scale fixes Taha Ed-Dafili
2026-08-17 21:11 ` [PATCH v4 1/6] dt-bindings: iio: dac: ad5504: add output-range and missing gpios Taha Ed-Dafili
2026-08-17 21:11 ` [PATCH v4 2/6] iio: dac: ad5504: Align headers with IWYU principle Taha Ed-Dafili
2026-08-18 4:43 ` Andy Shevchenko
2026-08-18 9:04 ` Uwe Kleine-König
2026-08-17 21:11 ` [PATCH v4 3/6] iio: dac: ad5504: remove legacy platform data support Taha Ed-Dafili
2026-08-18 4:45 ` Andy Shevchenko
2026-08-19 8:22 ` Taha Ed-Dafili
2026-08-19 13:21 ` Andy Shevchenko
2026-08-17 21:11 ` [PATCH v4 4/6] iio: dac: ad5504: introduce local lock to protect state and spi transfers Taha Ed-Dafili
2026-08-18 6:12 ` Andy Shevchenko
2026-08-18 8:36 ` Taha Ed-Dafili
2026-08-17 21:11 ` [PATCH v4 5/6] iio: dac: ad5504: strictly separate ACPI and DT probe paths Taha Ed-Dafili
2026-08-18 6:26 ` Andy Shevchenko
2026-08-19 8:40 ` Taha Ed-Dafili [this message]
2026-08-17 21:11 ` [PATCH v4 6/6] iio: dac: ad5504: support scale via output-range-microvolt property Taha Ed-Dafili
2026-08-18 6:30 ` Andy Shevchenko
2026-08-18 8:23 ` Taha Ed-Dafili
2026-08-18 8:33 ` Andy Shevchenko
2026-08-19 1:29 ` [PATCH v4 0/6] iio: dac: ad5504: bindings, cleanups, locking, and scale fixes Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819084045.16300-1-0rayn.dev@gmail.com \
--to=0rayn.dev@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox