From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Archit Anant <architanant5@gmail.com>,
dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com,
u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/8] iio: adc: ti-ads1015: fix PM leak on probe failure
Date: Sat, 22 Aug 2026 01:38:23 +0100 [thread overview]
Message-ID: <20260822013823.28b0a1e1@jic23-huawei> (raw)
In-Reply-To: <an2FkBoJNRCaeAkk@ashevche-desk.local>
On Thu, 13 Aug 2026 11:51:28 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Wed, Aug 12, 2026 at 10:14:27PM +0530, Archit Anant wrote:
> > If iio_device_register() fails during probe(), the runtime PM
> > subsystem is left enabled. This leads to a resource leak upon failure.
> >
> > Add the missing pm_runtime_disable() and pm_runtime_set_suspended()
> > calls to the probe() error path to ensure proper cleanup.
>
> > Reported-by: Jonathan Cameron <jic23@kernel.org>
>
> Was it public email?
>
> > Link: https://lore.kernel.org/linux-iio/20260718225515.7e49a458@jic23-huawei/
>
> Ah, this should be Closes: tag instead of Link.
>
I never checked but this is already fixed in the iio tree and
the relevant devm rework done. :( So much going on at the moment
in IIO I didn't recall this one at all!
https://lore.kernel.org/all/20260529183708.17819-1-sozdayvek@gmail.com/
Please rebase the remainder of the series.
Jonathan
next prev parent reply other threads:[~2026-08-22 0:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 16:44 [PATCH v3 0/8] iio: adc: ti-ads1015: modernize resource management Archit Anant
2026-08-12 16:44 ` [PATCH v3 1/8] iio: adc: ti-ads1015: use DEFINE_RUNTIME_DEV_PM_OPS() Archit Anant
2026-08-12 16:44 ` [PATCH v3 2/8] iio: adc: ti-ads1015: fix PM leak on probe failure Archit Anant
2026-08-13 8:51 ` Andy Shevchenko
2026-08-22 0:38 ` Jonathan Cameron [this message]
2026-08-24 4:54 ` Archit Anant
2026-08-12 16:44 ` [PATCH v3 3/8] iio: adc: ti-ads1015: sort headers alphabetically Archit Anant
2026-08-12 16:44 ` [PATCH v3 4/8] iio: adc: ti-ads1015: use local device pointer in probe Archit Anant
2026-08-12 16:44 ` [PATCH v3 5/8] iio: adc: ti-ads1015: use dev_err_probe() for error handling Archit Anant
2026-08-13 8:55 ` Andy Shevchenko
2026-08-12 16:44 ` [PATCH v3 6/8] iio: adc: ti-ads1015: convert to fully managed resources Archit Anant
2026-08-13 8:58 ` Andy Shevchenko
2026-08-12 16:44 ` [PATCH v3 7/8] iio: adc: ti-ads1015: replace custom shift macros with FIELD_PREP/GET Archit Anant
2026-08-13 9:02 ` Andy Shevchenko
2026-08-12 16:44 ` [PATCH v3 8/8] iio: adc: ti-ads1015: inline ads1015_set_conv_mode() Archit Anant
2026-08-13 9:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260822013823.28b0a1e1@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=architanant5@gmail.com \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox