From: Jonathan Cameron <jic23@kernel.org>
To: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
Cc: "Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chris Morgan" <macromorgan@hotmail.com>,
"Luca Weiss" <luca.weiss@fairphone.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/3] iio: imu: inv_icm42600: add support for icm42630
Date: Sun, 23 Aug 2026 18:42:11 +0100 [thread overview]
Message-ID: <20260823184211.1bc951b1@jic23-huawei> (raw)
In-Reply-To: <20260823003320.62192-1-jorijnvdgraaf@catcrafts.net>
On Sun, 23 Aug 2026 02:33:17 +0200
Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net> wrote:
> The TDK InvenSense ICM-42630 is a 6-axis IMU of the ICM-42600 family,
> used in the Fairphone 6. It needs no part-specific driver code: TDK
> confirmed it can be supported by inv_icm42600 without modification.
>
> The binding documents the new compatible with an invensense,icm42631
> fallback, and a WHOAMI mismatch no longer fails probe, so that a
> fallback-matched part can probe; one informational line records the
> mismatch, and a whoami of 0x00/0xff (no response) still fails. No
> driver id entries are added: the part binds through the fallback.
>
> Tested on the Fairphone 6 with the fallback pair in the devicetree,
> via a backport to its 7.1-based kernel: matched as icm42631 through
> the fallback, the part probes with the one informational line, and
> accelerometer, gyroscope and temperature reads work.
>
> Changes in v5:
> - patch 2: the no-response guard moves before the whoami-mismatch
> comparison as its own check (Andy); it does not depend on
> hw->whoami, since no supported part uses either value
> - patch 2: the four Link trailers are dropped (Andy, Jonathan); the
> Suggested-by tags carry the attribution
>
> v4: https://lore.kernel.org/all/20260810191157.125550-1-jorijnvdgraaf@catcrafts.net/
> v3: https://lore.kernel.org/all/20260728184351.75015-1-jorijnvdgraaf@catcrafts.net/
> v2: https://lore.kernel.org/all/20260724202708.128267-1-jorijnvdgraaf@catcrafts.net/
> v1: https://lore.kernel.org/all/20260720173411.82979-1-jorijnvdgraaf@catcrafts.net/
>
> Jorijn van der Graaf (3):
> iio: imu: inv_icm42600: sort device id tables numerically
> iio: imu: inv_icm42600: log whoami mismatch instead of failing probe
> dt-bindings: iio: imu: icm42600: add icm42630
Applied to the testing branch of iio.git. Note I'll be rebasing on rc1 once
available (in about 1 week) so until then I'm fine adding tags or with changes
on top if any review feedback comes in.
Thanks,
Jonathan
>
> .../bindings/iio/imu/invensense,icm42600.yaml | 24 +++++++++++--------
> .../iio/imu/inv_icm42600/inv_icm42600_core.c | 17 ++++++++++---
> .../iio/imu/inv_icm42600/inv_icm42600_i2c.c | 16 ++++++-------
> .../iio/imu/inv_icm42600/inv_icm42600_spi.c | 16 ++++++-------
> 4 files changed, 44 insertions(+), 29 deletions(-)
>
>
> base-commit: 350d1fb9204b13c5f95e511e98b8bcb47574d425
prev parent reply other threads:[~2026-08-23 17:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-23 0:33 [PATCH v5 0/3] iio: imu: inv_icm42600: add support for icm42630 Jorijn van der Graaf
2026-08-23 0:33 ` [PATCH v5 1/3] iio: imu: inv_icm42600: sort device id tables numerically Jorijn van der Graaf
2026-08-23 0:33 ` [PATCH v5 2/3] iio: imu: inv_icm42600: log whoami mismatch instead of failing probe Jorijn van der Graaf
2026-08-24 8:52 ` Andy Shevchenko
2026-08-23 0:33 ` [PATCH v5 3/3] dt-bindings: iio: imu: icm42600: add icm42630 Jorijn van der Graaf
2026-08-23 17:42 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260823184211.1bc951b1@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jorijnvdgraaf@catcrafts.net \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=macromorgan@hotmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox