From: Rupesh Majhi <zoone.rupert@gmail.com>
To: jic23@kernel.org
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Eddie James" <eajames@linux.ibm.com>,
"Joel Stanley" <joel@jms.id.au>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] iio: pressure: dps310: add triggered buffer support
Date: Mon, 24 Aug 2026 22:52:54 +0300 [thread overview]
Message-ID: <20260824200456.393895-1-zoone.rupert@gmail.com> (raw)
In-Reply-To: <20260823001914.224aba09@jic23-huawei>
On Sun, 23 Aug 2026 00:19:14 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> Use the sparse markings to make it clear and testable - thus not needing the
> comment. __must_hold(&data->lock)
Patch 6 opts dps310.o into the analysis, so they are checked and not just
documentation. Clean under clang 23.1.0, and it does run: dropping the
lock around dps310_fill_scan() fails the build. Patch is last and touches
only the Makefile, so drop it if IIO would rather not opt in yet.
> It isn't necessary to use guard/scoped_guard() for all locks in a driver
> if they actually hurt readability. I think that is the case here.
Plain lock and unlock in the trigger handler and in the FIFO work. Kept
guard() in the three places where the lock covers a whole function.
Rupesh
next prev parent reply other threads:[~2026-08-24 20:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 17:07 [PATCH v5 0/3] iio: pressure: dps310: FIFO and triggered buffer support Rupesh Majhi
2026-08-17 17:07 ` [PATCH v5 1/3] iio: pressure: dps310: fix CFG_REG bit definitions Rupesh Majhi
2026-08-17 17:07 ` [PATCH v5 2/3] iio: pressure: dps310: add triggered buffer support Rupesh Majhi
2026-08-22 23:19 ` Jonathan Cameron
2026-08-24 19:52 ` Rupesh Majhi [this message]
2026-08-17 17:07 ` [PATCH v5 3/3] iio: pressure: dps310: add hardware FIFO support Rupesh Majhi
2026-08-22 23:33 ` Jonathan Cameron
2026-08-24 20:08 ` Rupesh Majhi
2026-08-17 18:47 ` [PATCH v5 0/3] iio: pressure: dps310: FIFO and triggered buffer support Andy Shevchenko
2026-08-17 22:09 ` Rupert Zoone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260824200456.393895-1-zoone.rupert@gmail.com \
--to=zoone.rupert@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=eajames@linux.ibm.com \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox