From: Archit Anant <architanant5@gmail.com>
To: jic23@kernel.org
Cc: dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com,
u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Archit Anant <architanant5@gmail.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: [PATCH v4 5/8] iio: adc: ti-ads1015: drop unneeded < 0 error checks
Date: Thu, 27 Aug 2026 22:50:57 +0530 [thread overview]
Message-ID: <20260827172100.39176-6-architanant5@gmail.com> (raw)
In-Reply-To: <20260827172100.39176-1-architanant5@gmail.com>
Several functions in the driver only return 0 on success
or a negative error code on failure.
Change the error checking to align with standard kernel
coding style.
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Archit Anant <architanant5@gmail.com>
---
drivers/iio/adc/ti-ads1015.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
index 0d1006041819..ba4a01850531 100644
--- a/drivers/iio/adc/ti-ads1015.c
+++ b/drivers/iio/adc/ti-ads1015.c
@@ -539,7 +539,7 @@ static int __ads1015_read_info_raw(struct ads1015_data *data,
return -EBUSY;
ret = ads1015_set_power_state(data, true);
- if (ret < 0)
+ if (ret)
return ret;
ret = ads1015_get_adc_result(data, chan->address, val);
@@ -727,7 +727,7 @@ static int ads1015_enable_event_config(struct ads1015_data *data,
return ret;
ret = ads1015_set_power_state(data, true);
- if (ret < 0)
+ if (ret)
return ret;
ads1015_event_channel_enable(data, chan->address, comp_mode);
@@ -994,7 +994,7 @@ static int ads1015_probe(struct i2c_client *client)
ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,
ads1015_trigger_handler,
&ads1015_buffer_setup_ops);
- if (ret < 0)
+ if (ret)
return dev_err_probe(dev, ret,
"iio triggered buffer setup failed\n");
--
2.39.5
next prev parent reply other threads:[~2026-08-27 17:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 17:20 [PATCH v4 0/8] iio: adc: ti-ads1015: modernize driver Archit Anant
2026-08-27 17:20 ` [PATCH v4 1/8] iio: adc: ti-ads1015: use DEFINE_RUNTIME_DEV_PM_OPS() Archit Anant
2026-08-27 17:20 ` [PATCH v4 2/8] iio: adc: ti-ads1015: sort headers alphabetically Archit Anant
2026-08-27 17:20 ` [PATCH v4 3/8] iio: adc: ti-ads1015: use local device pointer in probe Archit Anant
2026-08-27 18:55 ` Andy Shevchenko
2026-08-27 17:20 ` [PATCH v4 4/8] iio: adc: ti-ads1015: use dev_err_probe() for error handling Archit Anant
2026-08-27 17:20 ` Archit Anant [this message]
2026-08-27 17:20 ` [PATCH v4 6/8] iio: adc: ti-ads1015: Convert to managed resources Archit Anant
2026-08-27 19:28 ` Andy Shevchenko
2026-08-27 17:20 ` [PATCH v4 7/8] iio: adc: ti-ads1015: replace custom shift macros with FIELD_PREP/GET Archit Anant
2026-08-27 19:32 ` Andy Shevchenko
2026-08-27 17:21 ` [PATCH v4 8/8] iio: adc: ti-ads1015: inline ads1015_set_conv_mode() Archit Anant
2026-08-27 19:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827172100.39176-6-architanant5@gmail.com \
--to=architanant5@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox