Re: [PATCH v2 0/4] inv_icm42600 driver enhancements

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 24 Aug 2026 14:30:06 +0200
Jean-Baptiste Maneyrol via B4 Relay <devnull+jean-baptiste.maneyrol.tdk.com@kernel.org> wrote:

> This series add enhancements patches to inv_icm42600 driver.
> 
> It includes:
> 1. Move of MEMS stabilization sleep before FIFO configuration to avoid
>    pushing incorrect data.
> 2. Use a fixed FIFO frame of 16 bits to avoid a bug of dynamic FIFO
>    configuration changed triggered by the sleep move.
> 3. Simplify watermark computation using gcd.
> 4. Enhance support of high frequency streaming by avoiding read of FIFO
>    count for watermark interrupt.
> 
> Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Whilst sashiko did have quite a lot to say I 'think' they are all fine.
However, please do take a look and if you disagree then shout.

https://sashiko.dev/#/patchset/20260824-inv-icm42600-enhacements-v2-0-0040837fde12%40tdk.com

It may well be there are things in there that should be patches on top anyway.
I think all but 1 were things it even thought were preexisting issues.

Anyhow applied to the testing branch of iio.git which i just rebased
on rc1.

Thanks,

Jonathan


> ---
> Changes in v2:
> - Add commentaries for easing understanding of changes.
> - Reword commit messages with better explanations.
> - Link to v1: https://patch.msgid.link/20260820-inv-icm42600-enhacements-v1-0-075a881db557@tdk.com
> 
> To: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> To: Jonathan Cameron <jic23@kernel.org>
> To: David Lechner <dlechner@baylibre.com>
> To: Nuno Sá <nuno.sa@analog.com>
> To: Andy Shevchenko <andy@kernel.org>
> Cc: linux-iio@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> 
> ---
> Jean-Baptiste Maneyrol (4):
>       iio: imu: inv_icm42600: sleep before enabling FIFO data
>       iio: imu: inv_icm42600: use 2 sensors fixed packet size of 16 bytes
>       iio: imu: inv_icm42600: simplify watermark computation by using GCD
>       iio: imu: inv_icm42600: do not read FIFO count for watermark it
> 
>  drivers/iio/imu/inv_icm42600/inv_icm42600.h        |   4 +-
>  drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c  |  16 ++-
>  drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c | 112 +++++++++------------
>  drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c   |  16 ++-
>  4 files changed, 73 insertions(+), 75 deletions(-)
> ---
> base-commit: 53c022f51fbe540fffee2121ce9ed3e15266c9a4
> change-id: 20260709-inv-icm42600-enhacements-1e0e18e6f868
> 
> Best regards,
> --  
> Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> 
>