From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: light: vcnl4000: use sysfs_emit() for near_level
Date: Mon, 31 Aug 2026 11:12:43 +0200 [thread overview]
Message-ID: <20260831111243.00001714@gmail.com> (raw)
In-Reply-To: <20260830185345.2209268-1-donggeunyoo.kernel@gmail.com>
On Mon, 31 Aug 2026 03:53:45 +0900
Donggeun Yoo <donggeunyoo.kernel@gmail.com> wrote:
> Use sysfs_emit() instead of sprintf() for writing to the sysfs
> output buffer. sysfs_emit() is aware of the buffer's PAGE_SIZE
> limit and is the preferred helper for sysfs callbacks.
>
> Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
> ---
Seems fine.
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards,
Joshua Crofts
next prev parent reply other threads:[~2026-08-31 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 18:53 [PATCH v2] iio: light: vcnl4000: use sysfs_emit() for near_level Donggeun Yoo
2026-08-31 9:12 ` Joshua Crofts [this message]
2026-09-01 16:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831111243.00001714@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=donggeunyoo.kernel@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox