From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Akshat Chandra <notmissinge@gmail.com>
Cc: linux-iio@vger.kernel.org, "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: chemical: add SGP41 driver
Date: Mon, 31 Aug 2026 23:21:57 +0200 [thread overview]
Message-ID: <20260831232157.27037a5e@systembl0wer> (raw)
In-Reply-To: <20260831151235.64076-1-notmissinge@gmail.com>
On Mon, 31 Aug 2026 20:42:35 +0530
Akshat Chandra <notmissinge@gmail.com> wrote:
> Signed-off-by: Akshat Chandra <notmissinge@gmail.com>
> ---
> .../devicetree/bindings/trivial-devices.yaml | 2 +
> drivers/iio/chemical/Kconfig | 11 +
> drivers/iio/chemical/Makefile | 1 +
> drivers/iio/chemical/sgp41.c | 384 ++++++++++++++++++
> 4 files changed, 398 insertions(+)
> create mode 100644 drivers/iio/chemical/sgp41.c
>
Not only you're missing a commit message, you're also missing a
MAINTAINERS entry and a dt-bindings entry! Please fix this!
(Note, the dt-bindings and MAINTAINERS entry should go together
in one patch, preferrably first in the series).
--
Kind regards,
Joshua Crofts
next prev parent reply other threads:[~2026-08-31 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 15:12 [PATCH] iio: chemical: add SGP41 driver Akshat Chandra
2026-08-31 17:27 ` Andy Shevchenko
2026-08-31 21:21 ` Joshua Crofts [this message]
2026-09-04 3:22 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831232157.27037a5e@systembl0wer \
--to=joshua.crofts1@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=notmissinge@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).