From: Conor Dooley <conor@kernel.org>
To: Shehryar Ahmad <shehryar.amd@gmail.com>
Cc: jic23@kernel.org, nuno.sa@analog.com,
Michael.Hennerich@analog.com, dlechner@baylibre.com,
andy@kernel.org, gregkh@linuxfoundation.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, linux@analog.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, devicetree@vger.kernel.org,
marcelo.schmitt1@gmail.com, danascape@gmail.com
Subject: Re: [PATCH 3/3] dt-bindings: iio: accel: adi,adis16201: add adis16203 compatible
Date: Tue, 1 Sep 2026 19:05:04 +0100 [thread overview]
Message-ID: <20260901-ambitious-eloquent-7dcb297a9e6a@spud> (raw)
In-Reply-To: <20260831184201.34416-4-shehryar.amd@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2240 bytes --]
On Mon, Aug 31, 2026 at 11:42:01PM +0500, Shehryar Ahmad wrote:
> The ADIS16203 has the same external interface as the already documented
> ADIS16201/ADIS16209, for the properties covered by this binding
> (compatible/reg, the DIO-based interrupt pin, and VDD supply), verified
> by datasheets Table 5, Pin Function Descriptions, in the respective
> Analog Devices datasheets. Some Auxiliary pins differ (e.g. adis16209
> marks a few pins DNC where adis16201/adis16203 use them as AUX COM), but
> these are not represented in this binding. Add adis16203 to the
> existing enum rather than creating a separate file.
>
> Signed-off-by: Shehryar Ahmad <shehryar.amd@gmail.com>
> ---
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Why is this below the --- line (IOW it won't appear when the patch is
applied)?
>
> Previously reviewed at:
> https://lore.kernel.org/all/20260812043506.456ced6d@jic23-huawei/
>
> .../devicetree/bindings/iio/accel/adi,adis16201.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adis16201.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adis16201.yaml
> index b6ba7ad1a..3ce5fb1be 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adis16201.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adis16201.yaml
> @@ -4,21 +4,23 @@
> $id: http://devicetree.org/schemas/iio/accel/adi,adis16201.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: ADIS16201 Dual Axis Inclinometer and similar
> +title: ADIS16201 Inclinometer and similar
>
> maintainers:
> - Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> description: |
> - Two similar parts from external interface point of view.
> + Three similar parts from external interface point of view.
> SPI interface.
> https://www.analog.com/en/products/adis16201.html
> + https://www.analog.com/en/products/adis16203.html
> https://www.analog.com/en/products/adis16209.html
>
> properties:
> compatible:
> enum:
> - adi,adis16201
> + - adi,adis16203
> - adi,adis16209
>
> reg:
> --
> 2.43.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-09-01 18:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 18:41 [PATCH 0/3] iio: accel: merge adis16203 into mainline adis16201 and remove from staging Shehryar Ahmad
2026-08-31 18:41 ` [PATCH 1/3] iio: accel: adis16201: merge adis16203 support " Shehryar Ahmad
2026-09-01 8:12 ` Andy Shevchenko
2026-08-31 18:42 ` [PATCH 2/3] staging: iio: accel: remove adis16203, merged into mainline adis16201 driver Shehryar Ahmad
2026-09-01 8:13 ` Andy Shevchenko
2026-08-31 18:42 ` [PATCH 3/3] dt-bindings: iio: accel: adi,adis16201: add adis16203 compatible Shehryar Ahmad
2026-09-01 18:05 ` Conor Dooley [this message]
2026-09-01 7:50 ` [PATCH 0/3] iio: accel: merge adis16203 into mainline adis16201 and remove from staging Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901-ambitious-eloquent-7dcb297a9e6a@spud \
--to=conor@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=danascape@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@analog.com \
--cc=marcelo.schmitt1@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=shehryar.amd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox