Linux IIO development
 help / color / mirror / Atom feed
From: "hpp.iscas" <hppiscas@163.com>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: "hpp.iscas" <hppiscas@163.com>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Jonathan Cameron <jic23@kernel.org>,
	David Lechner <dlechner@baylibre.com>,
	Andy Shevchenko <andy@kernel.org>,
	linux@analog.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] iio: cdc: ad7150: fix OF matching and publish module aliases
Date: Sat,  5 Sep 2026 21:39:39 +0800	[thread overview]
Message-ID: <20260905133939.66210-1-hppiscas@163.com> (raw)

The positional initializers in ad7150_of_match populate the name member
of struct of_device_id, not compatible. Consequently the table does not
match the compatible properties documented for AD7150, AD7151 and AD7156.
The table is also absent from the module alias metadata.

Use designated compatible initializers and publish the corrected table.
Keep the existing I2C ID fallback and per-device driver data unchanged.

Fixes: 89f2d5b080bc ("staging:iio:cdc:ad7150: Add of_match_table")
Signed-off-by: hpp.iscas <hppiscas@163.com>
---
 drivers/iio/cdc/ad7150.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/cdc/ad7150.c b/drivers/iio/cdc/ad7150.c
index 2f35c6d..b36ac4e 100644
--- a/drivers/iio/cdc/ad7150.c
+++ b/drivers/iio/cdc/ad7150.c
@@ -636,11 +636,13 @@ static const struct i2c_device_id ad7150_id[] = {
 MODULE_DEVICE_TABLE(i2c, ad7150_id);
 
 static const struct of_device_id ad7150_of_match[] = {
-	{ "adi,ad7150" },
-	{ "adi,ad7151" },
-	{ "adi,ad7156" },
+	{ .compatible = "adi,ad7150" },
+	{ .compatible = "adi,ad7151" },
+	{ .compatible = "adi,ad7156" },
 	{ }
 };
+MODULE_DEVICE_TABLE(of, ad7150_of_match);
+
 static struct i2c_driver ad7150_driver = {
 	.driver = {
 		.name = "ad7150",


             reply	other threads:[~2026-09-05 13:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-05 13:39 hpp.iscas [this message]
2026-09-05 23:11 ` [PATCH] iio: cdc: ad7150: fix OF matching and publish module aliases Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260905133939.66210-1-hppiscas@163.com \
    --to=hppiscas@163.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox