Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Salah Triki" <salah.triki@gmail.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux@analog.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: imu: adis16400: Check return value of spi_setup()
Date: Mon, 7 Sep 2026 03:20:36 +0100	[thread overview]
Message-ID: <20260907032036.15a115fe@jic23-huawei> (raw)
In-Reply-To: <apl3pwAZezUgEs0e@ashevche-desk.local>

On Thu, 3 Sep 2026 16:35:35 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Thu, Sep 03, 2026 at 01:27:33PM +0100, Salah Triki wrote:
> > In adis16400_initial_setup(), the return value of spi_setup() was ignored.
> > If SPI configuration fails, the driver would proceed with the
> > initialization anyway, leading to undefined behavior or silent failures
> > during device setup.
> > 
> > Check the return value of spi_setup() and return the error code immediately
> > if it fails.  
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 

I assume in practice this never fails, so treating this as hardening
rather than an urgent fix.  Applied to the testing branch of iio.git

Thanks,

Jonathan


      reply	other threads:[~2026-09-07  2:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 12:27 [PATCH] iio: imu: adis16400: Check return value of spi_setup() Salah Triki
2026-09-03 13:35 ` Andy Shevchenko
2026-09-07  2:20   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260907032036.15a115fe@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=salah.triki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox