From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Andrei Stancovici" <andrei.stancovici@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Liam Beguin" <liambeguin@gmail.com>,
linux@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] iio: adc: ltc2497: add 2x conversion speed mode
Date: Mon, 14 Sep 2026 00:38:17 +0100 [thread overview]
Message-ID: <20260914003817.760214ab@jic23-hlaptop> (raw)
In-Reply-To: <aqFniZF6CrYXnPjz@ashevche-desk.local>
On Wed, 9 Sep 2026 17:04:57 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Wed, Sep 09, 2026 at 11:27:52AM +0300, Andrei Stancovici wrote:
> > The LTC2499 can convert at twice the output rate by disabling the offset
> > auto-calibration. Expose it through sampling_frequency and
> > sampling_frequency_available on the voltage channels. The part ignores
> > the setting while measuring temperature, so the temperature channel does
> > not carry the attribute.
> >
> > The wait before a result is read is keyed on the conversion currently in
> > flight, whose duration is fixed by the mode that was active when it
> > started rather than by the mode just selected. Otherwise the first read
> > after a 1x -> 2x switch can reprogram the part while a 1x conversion is
> > still running, which the part NACKs.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> ...
>
> > +LTC2497_DEFINE_CHANNELS(ltc2497core_channel_samp_freq,
> > + BIT(IIO_CHAN_INFO_SAMP_FREQ));
>
> I believe having this on a single line is fine.
>
Tweaked.
I've taken the somewhat (currently) unusual step of picking up 2 and 3, but
not patch 1. In the past I've always been one to pick up whatever is ready
but since that started confusing sashiko I stopped doing so.
Here it doesn't matter as patch 1 is independent anyway!
So patches 2 and 3 are on the testing branch of iio.git.
Thanks,
Jonathan
prev parent reply other threads:[~2026-09-13 23:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 8:27 [PATCH v4 0/3] iio: adc: add LTC2499 features support Andrei Stancovici
2026-09-09 8:27 ` [PATCH v4 1/3] dt-bindings: iio: adc: lltc,ltc2497: add LTC2499 to title Andrei Stancovici
2026-09-13 23:32 ` Jonathan Cameron
2026-09-09 8:27 ` [PATCH v4 2/3] iio: adc: ltc2497: add LTC2499 internal temperature channel Andrei Stancovici
2026-09-09 8:27 ` [PATCH v4 3/3] iio: adc: ltc2497: add 2x conversion speed mode Andrei Stancovici
2026-09-09 14:04 ` Andy Shevchenko
2026-09-13 23:38 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914003817.760214ab@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andrei.stancovici@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox