From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2E6544238E for ; Mon, 14 Sep 2026 11:25:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789385102; cv=none; b=EA6vxkT52ZD2FEg7ayfS6rEFy73+lOeNucNLLs0pb5GtEbgZ7N0V57IiNsYlPOi3lJgjeHTcmY01/BlPrsKYL5NGN0cyIbH2wgWK7EJsbuB5MRE8h/1s9a2113Ev6ZW4vXRZoE5myuauG6H2d8WE2m59Edo2+Qz/L7O1UnlGe+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789385102; c=relaxed/simple; bh=m4FGhaq8a+nWJ/uaFh8Slz+kDyjA89yddHRxow0Aw0E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ym2xdeL5T3nsnVz860b8ZVytqHtVoT87LQwbw39wLX+2kxrnQ9587UomQ9MdTzGTlRJwRYpmQGD6teSl6B7tBkpmJw3tZNxjy7fXZOvbAy7fzHNN3NSJu1k1aQ/a+fQbwXJWReN0gbdMvgP6GzCX+HrCMpqP6uJI1aiYHDkw8VY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AJRGU/SL; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AJRGU/SL" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cfbbdfa60bso32847055ad.3 for ; Mon, 14 Sep 2026 04:25:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789385100; x=1789989900; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Ok3Mywemwoiloo46/07KIkWHT3aySpVf35ol5uj0s9I=; b=AJRGU/SLIRnyupW/xdeRu8jWd2r2g98r46bAaTo7KJZB7ouy+INlQWrdjtUDClR7mg RfDS8xvCPFDunyD4HQTak3d83PvjNmmhZ/JspQeJ3N6Hhc7EYhY6K5hfmF5SV6Y6f2+o mOhESJ2WZXsxqwghXHz7l7QmHRvS7WAQnzoCGc6rF+JMm6Q07CIOwmj2Ozc5CBnHWg5l eHMNLmG2mthgVSuoBFZvRtF54a+jTJMs7caxLdOrDry3dPV0n/nyEnl3BZmJbS/rrAyv yG3KHgSvYNw1+nPeY484XI5ZTMf6PfNL/bmunPqEIzPtnScnt+G0zINJnCp5P8sZfgbr yh5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789385100; x=1789989900; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ok3Mywemwoiloo46/07KIkWHT3aySpVf35ol5uj0s9I=; b=Q4fKuIRrWdYiFuQA+4Q2FMaUvQVUGCfZUVmW9ZgoUcYDytTWaTf7l6MoKV+eWpdo2Y PSQQbZ1cLNVdW7U0lQaYyIaYkU+FM/WGEZXZBHSTz5+4V1e/f0uIQG5UOBgue22CH42t L4v/QpA9DiNdc1vU4iFiWircZqJZYM0YNEVmt0VlkalhIBrXCXCe6IuYh2zPoI+hdE39 oocErIQrbsTDiPgbIy1shHvGQHGV8nPEQinD/1BquIBYkGjWXVLfsOzFCiKcCh1Ynms0 1UbEMtods0DhuUJYptWKAd6wC40FKtW1xt7PFey2reEhMXm9h6krGRaXIOhybsOAQaCx F/pg== X-Forwarded-Encrypted: i=1; AKwUvBy2unmQDPYuiivmH/cRMO4wyZkRKuQa7xaBfNv+PncKJ6MzJmDzSSYFmZ1MVFsiRSTfDxuPXFoMRSo=@vger.kernel.org X-Gm-Message-State: AFuF++ly1pzPLwcuSi5ehxAljr30k8VdVmL2GUhffgz1fI50tcAcdVxR llx0iDmBGClojo94osZt+AJnhCl3TC44v0rVdh2dA6krYvogCXakFN7O X-Gm-Gg: AYBFou0uE7TGNzCL80Uiiyf2Rp1jj+UD+s8aEpT/uAgK1l7vG7BVyxH2kLhxb8AruA5 hC7/DLATOTiHE9ic26sH2xiYFC8o4I04a6NR9EfsYxtxIWuVDKPGOM4mRAfPXikYRzm2o786Itb UfhaVmnA7wjoN/LIHRn5NpsvKMj1lFCgf3shtDjM0MpqBvJpo4iW48M/wzdLFicCWWXjMeKLJYu sAtNIj04gufBwawn9EvnUsNwdIsptzkVgVVHT48tJWtSdwyUBIdE12XIcMg9o2yzOG+gDQilOp5 NS8rft5khNNbvkWby3WL+J2AbCvqESN+Kto80VhJ4hIzpRPY0AsKaacKvAru73/lSSVXTGTEhRs F8ACHC/A1cC1khpXfBNLvu7F/afkX9XgE6SZ3pE2VyGe+qmnuTtGxtkj62jRojMxa1jH4/TUKFo sks3c4ltaoN3eWb5eBw91c87gVC5AL+tDnl/UIgF2i/NkL+wGbSSvvGg== X-Received: by 2002:a17:902:ecc6:b0:2da:eb8f:b4e4 with SMTP id d9443c01a7336-2dd6c5f3a7amr41335295ad.7.1789385100156; Mon, 14 Sep 2026 04:25:00 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1002::de93]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2dd69745cb5sm10810585ad.43.2026.09.14.04.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 04:24:59 -0700 (PDT) From: Guangshuo Li To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Guangshuo Li , Siratul Islam , Joshua Crofts , Pan Chuang , Irina Tirdea , Vlad Dogaru , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] iio: accel: mma9551: disable autosuspend on remove Date: Mon, 14 Sep 2026 19:24:47 +0800 Message-ID: <20260914112447.1686972-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mma9551_probe() enables runtime PM autosuspend with pm_runtime_use_autosuspend(). The probe error path correctly undoes this setting with pm_runtime_dont_use_autosuspend(), but the normal remove path only disables runtime PM. The runtime PM API requires pm_runtime_use_autosuspend() to be undone with pm_runtime_dont_use_autosuspend() at driver exit unless runtime PM was enabled with devm_pm_runtime_enable(). Leaving the autosuspend flag set therefore leaves the runtime PM state incompletely cleaned up after the driver is unbound. Add the missing pm_runtime_dont_use_autosuspend() call to the remove path. This issue was found by manual code inspection. Fixes: 6da93a6710a3 ("iio: accel: mma9551: Add runtime pm support") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/iio/accel/mma9551.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c index 7e01427fd9c4..182f488edab1 100644 --- a/drivers/iio/accel/mma9551.c +++ b/drivers/iio/accel/mma9551.c @@ -500,6 +500,7 @@ static void mma9551_remove(struct i2c_client *client) iio_device_unregister(indio_dev); + pm_runtime_dont_use_autosuspend(&client->dev); pm_runtime_disable(&client->dev); pm_runtime_set_suspended(&client->dev); -- 2.43.0