Linux IIO development
 help / color / mirror / Atom feed
From: Wentao Liang <vulab@iscas.ac.cn>
To: david@lechnology.com
Cc: jm@ti.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, wbg@kernel.org,
	Wentao Liang <vulab@iscas.ac.cn>,
	stable@vger.kernel.org
Subject: [PATCH] counter: ti-eqep: Fix runtime PM imbalance in ti_eqep_probe()
Date: Wed, 16 Sep 2026 07:22:47 +0000	[thread overview]
Message-ID: <20260916072247.1967830-1-vulab@iscas.ac.cn> (raw)

In ti_eqep_probe(), runtime PM is enabled and acquired via
pm_runtime_get_sync(dev). However, if devm_clk_get_enabled() fails,
the function returns directly without calling pm_runtime_put_sync()
and pm_runtime_disable(), leaving the runtime PM usage count and
enable state unbalanced.

Add the missing pm_runtime_put_sync() and pm_runtime_disable() calls
on the clock error path.

Fixes: 0cf81c73e4c6 ("counter: ti-eqep: enable clock at probe")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/counter/ti-eqep.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/counter/ti-eqep.c b/drivers/counter/ti-eqep.c
index d21c157e531a..84fbf500b0f8 100644
--- a/drivers/counter/ti-eqep.c
+++ b/drivers/counter/ti-eqep.c
@@ -548,8 +548,11 @@ static int ti_eqep_probe(struct platform_device *pdev)
 	pm_runtime_get_sync(dev);
 
 	clk = devm_clk_get_enabled(dev, NULL);
-	if (IS_ERR(clk))
+	if (IS_ERR(clk)) {
+		pm_runtime_put_sync(dev);
+		pm_runtime_disable(dev);
 		return dev_err_probe(dev, PTR_ERR(clk), "failed to enable clock\n");
+	}
 
 	err = counter_add(counter);
 	if (err < 0) {
-- 
2.34.1


             reply	other threads:[~2026-09-16  7:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16  7:22 Wentao Liang [this message]
2026-09-17  0:44 ` [PATCH] counter: ti-eqep: Fix runtime PM imbalance in ti_eqep_probe() Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916072247.1967830-1-vulab@iscas.ac.cn \
    --to=vulab@iscas.ac.cn \
    --cc=david@lechnology.com \
    --cc=jm@ti.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=wbg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox