From: Jonathan Cameron <jic23@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: andy@kernel.org, dlechner@baylibre.com, gustavograzs@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
nuno.sa@analog.com, stable@vger.kernel.org
Subject: Re: [PATCH] iio: chemical: ens160: Fix trigger reference leak in ens160_setup_trigger()
Date: Thu, 17 Sep 2026 01:30:00 +0100 [thread overview]
Message-ID: <20260917013000.40ba0e90@jic23-hlaptop> (raw)
In-Reply-To: <20260916162638.2083538-1-vulab@iscas.ac.cn>
On Wed, 16 Sep 2026 16:26:38 +0000
Wentao Liang <vulab@iscas.ac.cn> wrote:
> The reference taken with iio_trigger_get() is only dropped by
> iio_dev_release() when INDIO_BUFFER_TRIGGERED is set. Failure of
> devm_request_irq() in ens160_setup_trigger(), or of chip init or
> triggered buffer setup in devm_ens160_core_probe(), returns before
> that mode is set and leaks the reference acquired for indio_dev->trig.
> Request the IRQ before taking the reference and set up the trigger
> after the triggered buffer so that only failures with the mode
> already set follow the iio_trigger_get().
>
> Fixes: 0fc26596b4b3 ("iio: chemical: ens160: add triggered buffer support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Same again. Not this solution.
prev parent reply other threads:[~2026-09-17 0:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 16:26 [PATCH] iio: chemical: ens160: Fix trigger reference leak in ens160_setup_trigger() Wentao Liang
2026-09-17 0:30 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917013000.40ba0e90@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gustavograzs@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox