Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andrei Stancovici <andrei.stancovici@analog.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Liam Beguin" <liambeguin@gmail.com>,
	linux@analog.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] dt-bindings: iio: adc: lltc,ltc2497: generalise the title
Date: Mon, 21 Sep 2026 04:22:53 +0100	[thread overview]
Message-ID: <20260921042253.68cf40c0@jic23-hlaptop> (raw)
In-Reply-To: <20260917042612.2175ac4c@jic23-hlaptop>

On Thu, 17 Sep 2026 04:26:12 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Tue, 15 Sep 2026 17:46:24 +0300
> Andrei Stancovici <andrei.stancovici@analog.com> wrote:
> 
> > The title names two of the four parts the schema documents: the LTC2305
> > and the LTC2499 are in the compatible enum and in the description, but
> > not in the title. Rather than extend the list each time a part is added,
> > say "LTC2497 and similar ADCs", as bindings covering a large number of
> > parts tend to end up doing. The full list stays in the description.
> > 
> > Acked-by: Rob Herring (Arm) <robh@kernel.org>  
> 
> This is one where carrying the ack is not valid (unless I missed
> Rob saying he was fine with it). The whole patch was about the title
> which is now different!  Given the dt maintainers have automation
> around this I'm not sure anyone will take another look. Leave
> it a few days then send a v6 with Rob's Ack dropped.

Not worth poking Rob over, so I've dropped his tag and applied.
Thanks,

Jonathan

> 
> Thanks,
> 
> Jonathan
> 
> > Signed-off-by: Andrei Stancovici <andrei.stancovici@analog.com>
> > ---
> > Changes in v5:
> > - Only this patch is resent. Patches 2 and 3 of the v4 series ("add
> >   LTC2499 internal temperature channel" and "add 2x conversion speed
> >   mode") are already on the testing branch of iio.git, so v5 is a
> >   single-patch round.
> > - The title is now generalised instead of enumerating one more part.
> >   v4 added the LTC2499 to it; Sashiko then pointed out that the LTC2305
> >   is also supported and also missing, and Jonathan suggested stopping
> >   the enumeration and using "LTC2497 and similar" as bindings with many
> >   supported parts tend to do. The full list is already in the
> >   description and is left alone.
> > - Documentation only; no driver change, so no hardware run for this
> >   patch. The DC1012A-A validation previously reported covers the applied
> >   patches 2 and 3.
> > 
> > v4: https://lore.kernel.org/r/20260909082755.366269-1-andrei.stancovici@analog.com
> > 
> >  Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> > index c884b6e03767..67445ad2bb3b 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> > @@ -4,7 +4,7 @@
> >  $id: http://devicetree.org/schemas/iio/adc/lltc,ltc2497.yaml#
> >  $schema: http://devicetree.org/meta-schemas/core.yaml#
> >  
> > -title: Linear Technology / Analog Devices LTC2497 and LTC2309 ADC
> > +title: Linear Technology / Analog Devices LTC2497 and similar ADCs
> >  
> >  maintainers:
> >    - Michael Hennerich <michael.hennerich@analog.com>
> > 
> > base-commit: 36c12dbda81c284d72f3c64689461647497b643b  
> 
> 


      reply	other threads:[~2026-09-21  3:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15 14:46 [PATCH v5] dt-bindings: iio: adc: lltc,ltc2497: generalise the title Andrei Stancovici
2026-09-17  3:26 ` Jonathan Cameron
2026-09-21  3:22   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260921042253.68cf40c0@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andrei.stancovici@analog.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=liambeguin@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox