From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Arnav Kapoor <kapoorarnav43@gmail.com>
Cc: "Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: imu: inv_mpu6050: use named initializers for temp in hw_info[]
Date: Tue, 20 Oct 2026 09:59:36 +0200 [thread overview]
Message-ID: <20261020095936.00002ff3@gmail.com> (raw)
In-Reply-To: <20261018000924.758186-1-kapoorarnav43@gmail.com>
On Sun, 18 Oct 2026 05:39:13 +0530
Arnav Kapoor <kapoorarnav43@gmail.com> wrote:
> The temp member of struct inv_mpu6050_hw is initialized positionally
> in every entry of hw_info[], as { *_TEMP_OFFSET, *_TEMP_SCALE }. The
> order is correct today, but positional initializers of this kind are
> how the accel and gyro startup times ended up swapped.
>
> Use designated initializers, as already done for startup_time, so each
> value is assigned to the member it is named after.
>
> No functional change.
>
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
> Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
> ---
Your patch fails to apply, please check it out.
--
Kind regards,
Joshua Crofts
prev parent reply other threads:[~2026-10-20 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 0:09 [PATCH] iio: imu: inv_mpu6050: use named initializers for temp in hw_info[] Arnav Kapoor
2026-10-20 7:59 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020095936.00002ff3@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=kapoorarnav43@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox