From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.46 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792670043; b=G5TzIB2DkLQsbeftl6O+C46yQWdtqgysBECsRl6uDqo8SjpATa49LeYZ3pWfeKvwKuX3 ak18iFFO/Ftd3T0+ati3h5vRKubIOAGBWqKmYJVM4caXOiW+1XtQrkU0IaEkJ520kVtaN cvYmw6SNSC2/mWlGkktp0P/DGLrj81S1X6abUepflKN+8RJkHotA/rbhwjyx/H64PRdhF eULAhCNI7UQERsDvzuVE9RusfEgKW9W0Mj+N/Cs3sewAIRfWfe0T0XBvHHdgGH970esiU SJMZcZPGECDcP4m9BFBXiLSfhfY/fMK7qpTSKNNac+QV6aN7MbytawjXBbW8lkdp7dg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792670043; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:From:Subject:Date: Message-Id:MIME-Version:Content-Type:Content-Transfer-Encoding: X-B4-Tracking:X-Change-ID:To:Cc:X-Mailer; bh=FyyeM869JQGmn6ws97WbWxLYVyUrdcmnI0jr9iIidxM=; b=0nk9hG100diQausqC9ZuWlcgdmNY6gASEMnoJBw+GMJYO/oMzHafiy/nB+rBzSI7YmfP mkZgfStyS5u+T3seS18J6jXV0Ie6DjxGqaJgI/y2mCggqSELZz8duRP5GfgRSQqyYISvA qBDyzruKykJGPKuiaPAV/22uTI5Fh7axyUTYsvuvmisLXVxL90+wOZFn30qOXvTbEicts vuKD7zxCkv5qw83d23X+OE/yF9cx9G+pbNBtPcD7o3cDm6sF3ULRQ7SjD9PBrvp5Q6qJG wniLaRPmY3b4Td/XyfZgN6IIT7AGkLj94RW7jODUWKqd84LGLKybOrkYzfcXxaj4dbA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=l03uAgWH; arc=none smtp.remote-ip=209.85.221.46 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 460B3606A319 for ; Thu, 22 Oct 2026 11:54:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 460B3606A319 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=l03uAgWH Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-48dee593f18so1452442f8f.3 for ; Thu, 22 Oct 2026 04:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792670042; x=1793274842; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=FyyeM869JQGmn6ws97WbWxLYVyUrdcmnI0jr9iIidxM=; b=l03uAgWHLzkTBGKztx7BzXAucj33IonfhHxCDC4LESOGhJjOOBbyKHo8DfUkN7oqs1 KftQWIxGAHCPQRuHdaBUw6zI3BiRCjYcCFZp7DoLD2LgwYaYGOBmVDrjvHcN3yQVY/kf FWOtkfrXi5zrt4kpQgcUM/+Cnd2AcrINRSazztidY5aJD1tT4SKoLBXkjD+IOzGSBvNB S4Njq/oCAst1KImX0+1iYOs7M7oBXf+24tu6W+Rc40qJ16rbbUe5w4Tru/456waL+xG5 zECcdPA+1BWBK6dIKl9zHUXoPoaL1Nc2M7cg33zbDv1afsG9zg1ljw+d7PED7gVTMovL wvBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792670042; x=1793274842; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=FyyeM869JQGmn6ws97WbWxLYVyUrdcmnI0jr9iIidxM=; b=0IeAqcQBKowG/eim3rGo4s4W/8vJbgDj33Ed8GmnQqzKsjTpTHW/wP2dzVzKqY2tPB FtPKxZ7rJNw+ENQj4W5YfSzLZ37MmVc7j1hadplJedLdJadY0QnIOF5MH9Z1qdsZRlJu rEAz33qzBbEb75J1PmBP1A1QaDdu0M+kB8eD9wt6izfxCAVDiOxPu0Ol15tWaUzgF7lu gpVwbBo3PxuDwEWgsBNyV9HAuSvHPh1nz+D5kKtGYgZ1UH09tmXtp/707CnCZX4H7lGN y7F7UI4K4byAHx6po4dzTXjplaHEoeZO4Q1eYtC033uBs0r1VQqkpEhBdY9q+MDJ8jWR Lfow== X-Gm-Message-State: AFq9FYIyJ+ppFmbsGsErEk/FL2mblxt0wn/B9EfM/hFzctSF80klUDxU EPgH9oEahAG3jA4ECr5UXjXr/BiPYvDV6DgnZLC0RT7I4GD74jAutUMj X-Gm-Gg: AYBFou1skw8vxB5EwKQbuxJjQXReV4Q54DwM6AzoMbMz3TLep/Yw7a2pJ1myIiPft9f CBF7cJtKH1LrR5aFvAfxLpGpGYjcSgOuNkAMgVf35lKkAl27meM3G9EKkly7MmTyTxi6hcKSquw yLQfqEls9fJ5pTrasmdTFlWcnF3oO+sZRxyLum34vkwxho3lEoYKf5C6pGmAiAA/ewhYRWLK5rm yIS401nfg8kCajtj/1d4bk40NqX7+S8melbutMxMZkMtFlwoHcsSVVk/723fjmL5Wifg5f1gaoA MgupyTt8m7jtuhrUbg/nwmRbmP0ZsmQsrxSdNww2bhrxLTQbeNgWlr9O9Znw+C7t8gIJnmLaZKO E+vDyevkhXD14iOyzbnCqXbpUKY30Y6AXfawLi8WE3rxszDXtHiXSn8xEwdzhwnbE91ECUr8d/X //ufsA3PFttZoZowTpydhg2J7EIs2b1wc8GVpPhj1VNoG/N8l/5NIFoMbIz8nMcW+zVqiGaslMe NLemt4p1KCXfC7Qohnv6iQCjuc8gwm6BW8VSU+MBemHvGQDRaY9ekUFjrTcYjVICQcPdjtuwSNr WyNMy74NWQ== X-Received: by 2002:a05:6000:1184:b0:488:8384:c382 with SMTP id ffacd0b85a97d-48e264de064mr7813323f8f.49.1792670041474; Thu, 22 Oct 2026 04:54:01 -0700 (PDT) Received: from localhost (ip-94-113-240-150.net.vodafone.cz. [94.113.240.150]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e25828cbfsm11720004f8f.23.2026.10.22.04.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2026 04:54:01 -0700 (PDT) From: Jan Remes Subject: [PATCH v3 0/4] iio: light: tsl2591: fix lux calculation and precision, add I2C ID table, report saturation Date: Thu, 22 Oct 2026 13:53:56 +0200 Message-Id: <20261022-first-patch-v3-0-b792e89a429a@mycroftmind.com> X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/z2NzQqDMBCEX0X23EhcayA99T2Kh22MZlv/SFJpE d+90UKZ0wcz36wQrGcb4JKt4O3CgacxQXnKwDgaOyu4SQwoURWyOIuWfYhipmicwFJqbZSU2BC kxexty+/Ddqt/HF73hzVxV+wNxyFO/nPcLbj3/uYUVckcK61Ri0IYpudC/bUbiPvcTAPU27Z9A ZOB7EOxAAAA X-Change-ID: 20261014-first-patch-23099c6002da To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Joe Sandom Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Remes , Jonathan Cameron , stable@vger.kernel.org, Martin Triska , Andy Shevchenko X-Mailer: b4 0.16.0 This series fixes several issues found while using the TSL2591 in company products (Raspberry Pi CM5) and when testing (x86_64 laptops with MCP2221 USB-I2C bridge). The original field report found that the illumination value has always been 0.0 (caused by division by zero on ARM). Patch 1 fixes divisions by zero in the lux calculation, which occur with LOW gain and short integration times, or in darkness when CH0 = 0. Patch 2 adds an i2c_device_id table so the driver can be matched by name (e.g. via sysfs new_device) on kernels without CONFIG_OF. Patch 3 makes the driver return an error instead of a bogus value when the sensor is saturated. Patch 4 improves the formula for calculating lux values to make the returned value more accurate. Patches 3 and 4 change existing behavior, I am OK with splitting the series into two, if that makes things better. AI assistance: Claude Code (Claude Opus 5.5) was used for research on sensor behavior, datasheets and Adafruit library, to compare results produced by old and new formula, to draft some code for patches 1 and 4. I reviewed all of it and tested it on x86_64. Changes in v3: - Patch 2: Fix commit message, OF-only drivers can still be enumerated via DT or ACPI (PRP0001), only matching by name needs the I2C ID table (Andy) - Patch 2: Drop Andy's Reviewed-by - Rebase on current iio/testing - Link to v2: https://patch.msgid.link/20261014141650.259929-1-ciakval@gmail.com Changes in v2 (thanks to Andy Shevchenko for review): - Patch 2: Use C99 initializers - Patch 4: Keep variables in reversed xmas tree order - Link to v1: https://lore.kernel.org/r/20261013143943.436816-1-ciakval@gmail.com/ Signed-off-by: Jan Remes --- Jan Remes (4): iio: light: tsl2591: don't divide by zero iio: light: tsl2591: add I2C device ID table iio: light: tsl2591: report saturation iio: light: tsl2591: improve lux calculation precision drivers/iio/light/tsl2591.c | 58 ++++++++++++++++++++++++++++++++------------- 1 file changed, 42 insertions(+), 16 deletions(-) --- base-commit: 87e28db23d0384f3995c43ecc5ae2118b371edb5 change-id: 20261014-first-patch-23099c6002da Best regards, -- Jan Remes