From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.46 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792670044; b=2CVb4sfcdQSdHBpcAIPGC/3exBr/HuNjOPVtzkp7vvtMvVzKKESVyXj4kTd7F8VN7LoA 8uxlSEbWZ11e1jZ9J//up1pgYpstK/Gpu4LS/c1OCXG5bSgcQToriNxMgiCi8T5DKON1C /fVay7b42Q1xnq339rmkxff6VBWeEr2XO/czmkHrJX0cxK+b2J+MgVZLVr/IhSbSK+zYL Nbwc6Tx+GVUgiciQOgaUu38lnSpAzSYFX0HXO0a6jfwHBWOCquwi2wQ5tC5gj6PfB7vj5 EkXwBx7VdrfdazVL7QjsUWcmaW4hfJ4+5b4O7nUbcF3NFPludXNz2FDjduzmu11pLjw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792670044; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:From:Date:Subject: MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id: References:In-Reply-To:To:Cc:X-Mailer; bh=YxlCmOT7eJfl7d21JfpqssCKce37H2r+MwEthBjDzno=; b=sgUP8cS9Tf3wuVzk9Q2oiWazh/otwefycYHN2Ca7S+dQqpGJoj4d++bgHn96UPIYHZsX KIc9uc66aV8u6ZPtPzBkXdEllpU6BlHNY11uO8rQjNzNLRFNnNwWaq9RXbDlO6ZbWxG/t yJYOhgx25usB7oV6+6euuTvel6/qP/uLfstnZoho2JhXCGV/ii0mZbsFr3L8UCrCVi1io nqKlVqro/22Ni5YGmF+t5gH1ErkM+AXcKU/1p/1NnL1zQ03b9cKCtbgb9Iis8P1LILROy 6Y+cY1aXYd6Dypk5wALAw2ngWql0DMKCSw9ZRWPS3Y3WEWzhVcpFkEKB+bcEV/eMDNA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=ZfTRjXM5; arc=none smtp.remote-ip=209.85.128.46 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F6AC606A324 for ; Thu, 22 Oct 2026 11:54:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0F6AC606A324 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=ZfTRjXM5 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4a20803a757so2842145e9.0 for ; Thu, 22 Oct 2026 04:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792670042; x=1793274842; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YxlCmOT7eJfl7d21JfpqssCKce37H2r+MwEthBjDzno=; b=ZfTRjXM5P/KOG3kdqzn3/eIMY8HHK9gUtAuHjAUIDLapWpNiIuwgUoJEJxL3h4cYYV vrV2mknc0I/VVKhroieCkxEUzVEloT1zeR/QY0hrZ1v2GWHgqmpXpRfOHQEK/NYeApaI G7zxxXaNMwAJdWYBAbp9OxMT0fgB8wuyycvvIg/oEWLm2jz1z2fJEY0ycaDLTQBdXFEs n4gT53cuqJRvjbea0+a0d3tqVJrl4SaUQVD4CvLLU79gSIGLqoTBXL9PSoiGmLdRgu7t 5pVHm6vgT8Te5A/JNBF3q49Asr8y5fn8sznyQaikZxVyARoioC6bYdYxnskdpWqP4B0v mdsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792670042; x=1793274842; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YxlCmOT7eJfl7d21JfpqssCKce37H2r+MwEthBjDzno=; b=iKGBSt18mz56Unei1ILd87CPqQDiEzVKHY5BTdrW3JAjiAzI9ANnMPpB701/OWQ8Ac xgQ1yoYKMXlWrKLO2awljsoOtzQ+j6T27Yj0qOxZfK7QoCjmqx1LXn0SKpun/2LcNnU+ DOrTbtLVhslZm7oRJDHJkBnX13WX35gEluMgYqCAqw+cgvRXq3QLQiCrpkhFZ/mpN5mH iW3yXDCsdRC7YNiLa70fqxZlj2IbhWeZ8j7YVNwS0vIcTYATbyHyKSLhjTYWEOsPXry1 TiOJ6he3ryZWNn9zlyz3m7annfo8542ZTVrXfIXuZE0TYS+XyLDDg7Zg2vDUan2Kg0xC s6ag== X-Gm-Message-State: AFq9FYJOid+pr69xWArAdVo6lCIg88VRegexj2Sv4bp1VgzichuXi/Fa /YBnRu3dmfqeC/3TvQEs+kUkZ+1d7sTG7Dpw/8UddZkBcKtVD16XugLm X-Gm-Gg: AYBFou2TnqOCfcJXgqhuFYN25lVFvRutLPg9KVRPOJIwl5N7F3uukC0/hKSFgDnUAqw FveWtYQ0eUh0ux1cRwq0Vn58dymgDl0eE3SPJf9k3o7eYpGKJucfJ53dC+O8wcUkz2vrylgDa7g EIQHI6iOCKicMUZKnc7X2elv/zZC3qryF3WXU6QvbBAvKurvjJTTOwM92sy/igKDsORwqYcBPy2 OIkQMRCn6xMetSuu3Oeee4M5QJah2DcHPtPAAbt2i/MXp9tITXWEIWnGgWJh5X6s8nU2B6NQiYw 93wxwpIDEO8J/5L0rbXuozf6sHWSnDbqDgqhDm4UB+ECEGYYW2YEFJS2e+UozEgTi8qASDtiJO/ 2UQ9+czIZ7ymFuTGVYlUfkhjp5FAWI2L3YJxzsIkwnZpQhMNTIO6MBhMiukadQ/DtGbrGSPPyTe 8bCMVcoyoUGKVaui02JmVlYt8EWGHoyDRUPYbYymeqsY2TSM/NvD8RJIUfYXUKEbkmPN5xo+jt/ 7ZgMEGivka4R9d29H9+ncpx2i99CCc7J7JP9P8hD3+v43yjh+9cp+e25RR2idPX9LsJXp7lPJhm wy/mkXhGxg== X-Received: by 2002:a05:600c:34ce:b0:4a1:dbdf:17a8 with SMTP id 5b1f17b1804b1-4a1fd8a7d77mr102657805e9.2.1792670042298; Thu, 22 Oct 2026 04:54:02 -0700 (PDT) Received: from localhost (ip-94-113-240-150.net.vodafone.cz. [94.113.240.150]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e25828ca3sm11613395f8f.25.2026.10.22.04.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2026 04:54:01 -0700 (PDT) From: Jan Remes Date: Thu, 22 Oct 2026 13:53:57 +0200 Subject: [PATCH v3 1/4] iio: light: tsl2591: don't divide by zero X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261022-first-patch-v3-1-b792e89a429a@mycroftmind.com> References: <20261022-first-patch-v3-0-b792e89a429a@mycroftmind.com> In-Reply-To: <20261022-first-patch-v3-0-b792e89a429a@mycroftmind.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Joe Sandom Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Remes , Jonathan Cameron , stable@vger.kernel.org, Martin Triska , Andy Shevchenko X-Mailer: b4 0.16.0 From: Jan Remes The TSL2591 has two raw light channels - CH0 and CH1. The algorithm for calculating illumination from the raw channels requires division by CH0 (which can be zero) and by "counts per lux" (CPL) value which is also zero for (gain = LOW, integration time <= 400 ms). Furthermore, the algorithm assumes CH0 > CH1, which can be violated in almost complete darkness. As a result, reading from 'in_illuminance_input' results in division-by-zero whenever CH0 is 0 (complete darkness) or whenever the parameters result in CPL being zero. This results in kernel oops on x86_64 and in reading the value as 0 on arm64. Fix that by: - reporting CH0 <= CH1 as zero (catches also CH0 = 0) - updating the lux algorithm to only do the division at the end Fixes: 2335f0d7c790 ("iio: light: Added AMS tsl2591 driver implementation") Cc: stable@vger.kernel.org Reported-by: Martin Triska Assisted-by: LLM Reviewed-by: Andy Shevchenko Signed-off-by: Jan Remes --- drivers/iio/light/tsl2591.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/iio/light/tsl2591.c b/drivers/iio/light/tsl2591.c index ef3ed9635a1e..f56d31404c25 100644 --- a/drivers/iio/light/tsl2591.c +++ b/drivers/iio/light/tsl2591.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -362,6 +363,10 @@ static int tsl2591_wait_adc_complete(struct tsl2591_chip *chip) * Scale values to get more representative value of lux i.e. * lux = ((C0DATA - C1DATA) * (1000 - ((C1DATA * 1000) / C0DATA))) / CPL * + * CPL is not computed on its own: at 1x gain it is below 1 for integration + * times under 500 ms, so the division by LUX DF is folded into the final + * division instead. + * * Channel 0 = IR + Visible * Channel 1 = IR only */ @@ -373,8 +378,10 @@ static int tsl2591_read_channel_data(struct iio_dev *indio_dev, struct tsl2591_als_settings *settings = &chip->als_settings; struct i2c_client *client = chip->client; u8 als_data[TSL2591_NUM_DATA_REGISTERS]; - int counts_per_lux, int_time_fval, gain_multi, lux; + int int_time_fval, gain_multi; u16 als_ch0, als_ch1; + u64 lux; + u32 rem; int ret; ret = tsl2591_wait_adc_complete(chip); @@ -410,23 +417,28 @@ static int tsl2591_read_channel_data(struct iio_dev *indio_dev, return gain_multi; } - int_time_fval = TSL2591_FVAL_TO_MSEC(settings->als_int_time); - /* Calculate counts per lux value */ - counts_per_lux = (int_time_fval * gain_multi) / TSL2591_LUX_COEFFICIENT; + /* No visible light, this also catches C0DATA == 0 */ + if (als_ch0 <= als_ch1) { + *val = 0; + *val2 = 0; + break; + } - dev_dbg(&client->dev, "Counts Per Lux: %d\n", counts_per_lux); + int_time_fval = TSL2591_FVAL_TO_MSEC(settings->als_int_time); /* Calculate lux value */ - lux = ((als_ch0 - als_ch1) * - (1000 - ((als_ch1 * 1000) / als_ch0))) / counts_per_lux; + lux = (u64)(als_ch0 - als_ch1) * + (1000 - ((als_ch1 * 1000) / als_ch0)) * + TSL2591_LUX_COEFFICIENT; + lux = div_u64(lux, int_time_fval * gain_multi); - dev_dbg(&client->dev, "Raw lux calculation: %d\n", lux); + dev_dbg(&client->dev, "Raw lux calculation: %llu\n", lux); /* Divide by 1000 to get real lux value before scaling */ - *val = lux / 1000; + *val = div_u64_rem(lux, 1000, &rem); /* Get the decimal part of lux reading */ - *val2 = (lux - (*val * 1000)) * 1000; + *val2 = rem * 1000; break; default: -- 2.53.0