Re: [PATCH 32/39] iio: adc: ad7887: use iio_push_to_buffers_with_ts()

[Joshua Crofts <crofts@kernel.org>]

On Tue, 27 Oct 2026 12:24:14 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Mon, Oct 26, 2026 at 04:05:50PM -0700, Jonathan Cameron wrote:
> > Replace the deprecated iio_push_to_buffers_with_timestamp() with
> > iio_push_to_buffers_with_ts(), passing the size of the pushed buffer,
> > which is a structure within the iio_priv() data.
> > 
> > Replace the data buffer with one declared via
> > IIO_DECLARE_DMA_BUFFER_WITH_TS(), for 2 __be16 channels.
> > 
> > Use be16_to_cpu() to replace the opencoded equivalent.  
> 
> ...
> 
> > Otherwise I might just rip out the pdata path in the near future.
> > This patch being an example of how it is causing maintenance burden.  
> 
> I don't see users in the kernel, I think we may just drop it for good.
> If anybody wants that, they can use software nodes in the future, no
> revert will even be considered.
> 
> ...
> 
> > -	return (st->data[(ch * 2)] << 8) | st->data[(ch * 2) + 1];
> > +	return be16_to_cpu(st->data[ch]);  
> 
> Add asm/byteorder.h into include block. And yes, the include block is a mess
> in this driver.
> 

I will probably do a series removing kernel.h from a subset of drivers
in IIO again (it's really painful though).

-- 
Kind regards,
Joshua Crofts