Re: [PATCH 1/5] iio: Remove redundant probe error messages for HID device drivers

[Joshua Crofts <crofts@kernel.org>]

On Thu, 05 Nov 2026 18:11:43 +0530
Sanjay Chitroda via B4 Relay <devnull+sanjayembeddedse.gmail.com@kernel.org> wrote:

...

> @@ -377,20 +377,16 @@ static int hid_accel_3d_probe(struct platform_device *pdev)
>  
>  	ret = devm_hid_sensor_setup_trigger(dev, indio_dev, name,
>  					    &accel_state->common_attributes);
> -	if (ret < 0) {
> -		dev_err(&pdev->dev, "trigger setup failed\n");
> +	if (ret < 0)

You could also remove the comparison and just change the checks to `if (ret)`,
as devm_hid_sensor_setup_trigger() always returns zero on success.

>  		return ret;
> -	}
>  
>  	accel_state->callbacks.send_event = accel_3d_proc_event;
>  	accel_state->callbacks.capture_sample = accel_3d_capture_sample;
>  	accel_state->callbacks.pdev = pdev;
>  	ret = devm_sensor_hub_register_callback(dev, hsdev, hsdev->usage,
>  						&accel_state->callbacks);
> -	if (ret < 0) {
> -		dev_err(&pdev->dev, "callback reg failed\n");
> +	if (ret < 0)
>  		return ret;
> -	}
>  
>  	return devm_iio_device_register(dev, indio_dev);


-- 
Kind regards,
Joshua Crofts