Linux IIO development
 help / color / mirror / Atom feed
From: Joshua Crofts <crofts@kernel.org>
To: "Adil Hüsrev Tepe" <tadilhusrev@gmail.com>
Cc: jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
	andy@kernel.org, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] iio: proximity: add Imagis ISG5320A (Samsung Galaxy XCover5)
Date: Wed, 18 Nov 2026 10:00:40 +0100	[thread overview]
Message-ID: <20261118100040.0000744a@kernel.org> (raw)
In-Reply-To: <20261117173333.1853986-1-tadilhusrev@gmail.com>

On Tue, 17 Nov 2026 20:33:31 +0300
Adil Hüsrev Tepe <tadilhusrev@gmail.com> wrote:

> This series adds an IIO driver and its DT binding for the Imagis
> ISG5320A capacitive SAR/grip proximity sensor (I2C), as fitted on the
> Samsung Galaxy XCover5 (SM-G525F, Exynos850).
> 
>   Patch 1  dt-bindings
>   Patch 2  the IIO driver
> 
> v3 fixes the real review findings on v2: Sashiko AI caught a High-
> severity INT-polarity bug in the reset sequence (eliminated by
> dropping int-gpios from the driver and binding entirely, since the
> pin is already described by the required "interrupts" property) plus
> a Medium-severity devm unwind-order bug and a Low-severity unchecked
> enable_irq_wake(). Both are now live-tested, not just built. Per-patch
> details are below each patch's "---" line, as Andy Shevchenko asked.
> 
> Tested on a Samsung Galaxy XCover5 running 7.4-rc1 plus this series
> (2026-11-17, kernel 7.4.0-rc1-00023-gdcb8b91fb779+ #30): the driver
> binds, registers as iio:device4 "isg5320a", and in_proximity0_raw
> tracked a live hand-proximity test (baseline ~0, swinging to
> -12817/9748/10759 as a hand approached/withdrew the sensor).
> checkpatch.pl --strict and dt_binding_check are clean.
> 
> Based on v7.4-rc1.
> 
> Tool usage
> ----------
> This series was developed during XCover5 mainline bring-up with the
> help of an AI coding assistant (Claude Code, Anthropic), which drafted
> the IIO driver from the Samsung vendor driver's register map and
> drafted these changelogs. I reviewed every line, built it (arm64, 0
> warnings), ran checkpatch --strict (clean), and tested it on hardware
> as described above, and take full responsibility for the contribution.
> Review comments are welcome and I will answer them myself.
> 
> Adil Hüsrev Tepe (2):
>   dt-bindings: iio: proximity: add Imagis ISG5320A
>   iio: proximity: add Imagis ISG5320A SAR sensor driver
> 
>  .../bindings/iio/proximity/imagis,isg5320a.yaml   |  55 ++
>  drivers/iio/proximity/Kconfig                     |  11 +
>  drivers/iio/proximity/Makefile                    |   1 +
>  drivers/iio/proximity/isg5320a.c                  | 848 +++++++++++++++++++
>  4 files changed, 915 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/proximity/imagis,isg5320a.yaml
>  create mode 100644 drivers/iio/proximity/isg5320a.c
> 
> --
> 2.53.0
> 

Not only you sent this as a reply to v1 (which obscured this new version
in my inbox), you also sent a v3 the same day you sent a v2. This is a (relatively)
big addition, please don't do this. For trivial patches it should be at least 24 hours
between revisions, for new drivers ~1 week.

I know it's tempting to send a new version after a Sashiko review/trivial issue you
found, but you'll save the reviewers' and maintainer's sanity by waiting :)

Thanks!

-- 
Kind regards,
Joshua Crofts

      parent reply	other threads:[~2026-11-18  9:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  7:40 [PATCH v1 0/2] iio: proximity: add Imagis ISG5320A (Samsung Galaxy XCover5) Adil Hüsrev Tepe
2026-11-16  7:40 ` [PATCH v1 1/2] dt-bindings: iio: proximity: add Imagis ISG5320A Adil Hüsrev Tepe
2026-11-16  7:40 ` [PATCH v1 2/2] iio: proximity: add Imagis ISG5320A SAR sensor driver Adil Hüsrev Tepe
2026-11-16 10:53   ` Andy Shevchenko
2026-11-16 10:48 ` [PATCH v1 0/2] iio: proximity: add Imagis ISG5320A (Samsung Galaxy XCover5) Andy Shevchenko
2026-11-17 10:44 ` [PATCH v2 1/2] dt-bindings: iio: proximity: add Imagis ISG5320A Adil Hüsrev Tepe
2026-11-17 10:44   ` [PATCH v2 2/2] iio: proximity: add Imagis ISG5320A SAR sensor driver Adil Hüsrev Tepe
2026-11-17 13:56     ` Andy Shevchenko
2026-11-17 17:33 ` [PATCH v3 0/2] iio: proximity: add Imagis ISG5320A (Samsung Galaxy XCover5) Adil Hüsrev Tepe
2026-11-17 17:33   ` [PATCH v3 1/2] dt-bindings: iio: proximity: add Imagis ISG5320A Adil Hüsrev Tepe
2026-11-17 17:33   ` [PATCH v3 2/2] iio: proximity: add Imagis ISG5320A SAR sensor driver Adil Hüsrev Tepe
2026-11-18  9:00   ` Joshua Crofts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118100040.0000744a@kernel.org \
    --to=crofts@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=tadilhusrev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox