From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts <crofts@kernel.org>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
linux-iio@vger.kernel.org, "Peter Rosin" <peda@lysator.liu.se>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH v1 1/1] iio: afe: rescale: Don't use ULL(1) << x instead of BIT(x)
Date: Sun, 22 Nov 2026 00:37:54 +0000 [thread overview]
Message-ID: <20261122003754.66fa693c@jic23-hlaptop> (raw)
In-Reply-To: <20261118092812.000014b3@kernel.org>
On Wed, 18 Nov 2026 09:28:12 +0100
Joshua Crofts <crofts@kernel.org> wrote:
> On Tue, 17 Nov 2026 11:12:16 +0100
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > ULL(1) << x is just an open-coded implementation of BIT_ULL().
> > Replace the former by the latter.
> >
> > Note, the rest of the code properly uses BIT()/BIT_ULL() already.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
>
> This file could get IWYU'd as well at some point.
>
> Reviewed-by: Joshua Crofts <crofts@kernel.org>
>
Applied with title tweaked to mention BIT_ULL(x)
prev parent reply other threads:[~2026-11-22 0:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 10:12 [PATCH v1 1/1] iio: afe: rescale: Don't use ULL(1) << x instead of BIT(x) Andy Shevchenko
2026-11-18 8:28 ` Joshua Crofts
2026-11-22 0:37 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261122003754.66fa693c@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=crofts@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=peda@lysator.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox