From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>,
Marcin Niestroj <m.niestroj@grinn-global.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Gregor Boirie <gregor.boirie@parrot.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 1/2] iio: st_pressure: Fix data sign
Date: Fri, 30 Dec 2016 11:33:25 +0000 [thread overview]
Message-ID: <2122e227-20f8-df7a-c166-c135053c95cb@kernel.org> (raw)
In-Reply-To: <CACRpkdYa5+SzgbJTqWiffnu-dwXWmDnBAv6e_G9piJ=8f4GGqg@mail.gmail.com>
On 13/12/16 08:51, Linus Walleij wrote:
> On Mon, Dec 12, 2016 at 5:58 PM, Marcin Niestroj
> <m.niestroj@grinn-global.com> wrote:
>
>> Datasheet of each device (lps331ap, lps25h, lps001wp, lps22hb) says that
>> the pressure and temperature data is a 2's complement.
>>
>> Fixes: 217494e5b780 ("iio:pressure: Add STMicroelectronics pressures driver")
>> Fixes: 2f5effcbd097 ("iio: pressure-core: st: Expand and rename LPS331AP's channel descriptor")
>> Fixes: 7885a8ce6800 ("iio: pressure: st: Add support for new LPS001WP pressure sensor")
>> Fixes: e039e2f5b4da ("iio:st_pressure:initial lps22hb sensor support")
>> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
>
> Looks correct. I guess noone thought of testing negative pressures :/
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
I've applied to the togreg branch of iio.git - initially pushed out as testing
because the very nature of a fix for multiple previous patches will make it tricky
to apply to older kernels.
If you want to do backports after it has gone into mainline, they'll be most
welcome.
Thanks,
Jonathan
>
> Yours,
> Linus Walleij
>
prev parent reply other threads:[~2016-12-30 11:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 16:58 [PATCH 1/2] iio: st_pressure: Fix data sign Marcin Niestroj
2016-12-12 16:58 ` [PATCH 2/2] iio: st_pressure: Export sampling frequency for lps25h and lps331ap Marcin Niestroj
2016-12-13 8:52 ` Linus Walleij
2016-12-30 11:34 ` Jonathan Cameron
2016-12-13 8:51 ` [PATCH 1/2] iio: st_pressure: Fix data sign Linus Walleij
2016-12-30 11:33 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2122e227-20f8-df7a-c166-c135053c95cb@kernel.org \
--to=jic23@kernel.org \
--cc=gregor.boirie@parrot.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=m.niestroj@grinn-global.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).