From: David Lechner <dlechner@baylibre.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Dumitru Ceclan <mitrutzceclan@gmail.com>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Nuno Sa <nuno.sa@analog.com>, Michael Walle <michael@walle.cc>,
Andy Shevchenko <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Guillaume Ranquet <granquet@baylibre.com>
Subject: Re: [PATCH 1/2] iio: adc: ad7313: fix irq number stored in static info struct
Date: Mon, 25 Nov 2024 08:57:48 -0600 [thread overview]
Message-ID: <213f4510-0af3-4e17-8473-3929227bcfcf@baylibre.com> (raw)
In-Reply-To: <76myaxinjuupszvwof355gxwqqs75yxupsy623nwrcms2g7ttu@q3vqdwmsp2ua>
On 11/25/24 2:59 AM, Uwe Kleine-König wrote:
> Hello,
>
> first of all thanks for picking up my report.
>
> $Subject ~= s/ad7313/ad7173/
>
> I wonder if it would make sense to update the ad7173 binding to also
> allow specifying the irq as the other ADCs do it and just
> unconditionally fall back to rdy-interrupt (or the other way round)?
> There is no good reason for ad7173 being special, is there?
>
> Best regards
> Uwe
That is a a good point. We actually don't have to change the DT
bindings, the "rdy" interrupt is already specified to be the first
interrupt, so spi->irq should already be the "rdy" interrupt
because is is always getting the interrupt at index 0. So we should
be able to just drop the special handling altogether.
next prev parent reply other threads:[~2024-11-25 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 17:39 [PATCH 0/2] iio: adc: ad7313: fix non-const info struct David Lechner
2024-11-22 17:39 ` [PATCH 1/2] iio: adc: ad7313: fix irq number stored in static " David Lechner
2024-11-25 8:59 ` Uwe Kleine-König
2024-11-25 14:57 ` David Lechner [this message]
2024-11-22 17:39 ` [PATCH 2/2] iio: adc: ad7173: make struct ad_sigma_delta_info ad7173_sigma_delta_info const David Lechner
2024-11-24 17:48 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=213f4510-0af3-4e17-8473-3929227bcfcf@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=granquet@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=mitrutzceclan@gmail.com \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox