linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>, linux-iio@vger.kernel.org
Cc: Giuseppe BARBA <giuseppe.barba@st.com>
Subject: Re: [PATCH] iio: st_sensors: fix errorcheck for regulators
Date: Sat, 3 Sep 2016 17:23:11 +0100	[thread overview]
Message-ID: <21a68cd4-7eef-dbac-1a08-ffbb58eb4827@kernel.org> (raw)
In-Reply-To: <1472545119-8092-1-git-send-email-linus.walleij@linaro.org>

On 30/08/16 09:18, Linus Walleij wrote:
> We were checking the return code of vdd when we should be checking
> vdd_io. My mistake, mea culpa.
> 
> Cc: Giuseppe BARBA <giuseppe.barba@st.com>
> Reported-by: Giuseppe BARBA <giuseppe.barba@st.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Applied to the togreg branch of iio.git.

Thanks,

Jonathan
> ---
>  drivers/iio/common/st_sensors/st_sensors_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c
> index 41bfe1c5f4e9..285a64a589d7 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_core.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_core.c
> @@ -247,9 +247,9 @@ int st_sensors_power_enable(struct iio_dev *indio_dev)
>  	}
>  
>  	pdata->vdd_io = devm_regulator_get(indio_dev->dev.parent, "vddio");
> -	if (IS_ERR(pdata->vdd)) {
> +	if (IS_ERR(pdata->vdd_io)) {
>  		dev_err(&indio_dev->dev, "unable to get Vdd_IO supply\n");
> -		err = PTR_ERR(pdata->vdd);
> +		err = PTR_ERR(pdata->vdd_io);
>  		goto st_sensors_disable_vdd;
>  	}
>  	err = regulator_enable(pdata->vdd_io);
> 


      reply	other threads:[~2016-09-03 16:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-30  8:18 [PATCH] iio: st_sensors: fix errorcheck for regulators Linus Walleij
2016-09-03 16:23 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21a68cd4-7eef-dbac-1a08-ffbb58eb4827@kernel.org \
    --to=jic23@kernel.org \
    --cc=giuseppe.barba@st.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).