From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.olsak.net (mx.olsak.net [37.205.8.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 889BF1632DD; Sat, 30 Aug 2025 13:07:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=37.205.8.231 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756559248; cv=none; b=HxTL/J5PsuiTXNAf1bg34N99K4GmVSvuS7hrKYkMRny1ZDOlmCZTyk2uUhxxPpdxNVZ8y8AlTERKAlW5N0TfeQxHnvwcUDn66AoBm63OlrVYz+PC86BSDY/8vXAqoBwSsBbIX7/oNHBgYEFOxKB6cSXb/i0Vb8cxOKOcRgwCd1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756559248; c=relaxed/simple; bh=5KS0O4ZGTJRuZ+XjiT1yQ7ysM3FbhtQFxAlV7ZUyxuM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SB1ubuHAjk1wZLPLaivdhS3Bq/PbfGQgz5KRxOX1yAG0R8v7xtc8TJut46bQlWzeI+fXWKJWbVjNF0nrGYhFuQKKuxQC6jCIQieXDWzf3BQ+h2JRRVe1mr6j0QUoV+YjF5IZVxeeQkj5VJdhQ/w6scCwEW81WfJxTil2rD4VKSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=dujemihanovic.xyz; spf=pass smtp.mailfrom=dujemihanovic.xyz; dkim=pass (2048-bit key) header.d=dujemihanovic.xyz header.i=@dujemihanovic.xyz header.b=OOZeaIUx; arc=none smtp.client-ip=37.205.8.231 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=dujemihanovic.xyz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dujemihanovic.xyz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dujemihanovic.xyz header.i=@dujemihanovic.xyz header.b="OOZeaIUx" DKIM-Signature: a=rsa-sha256; bh=mxXxkZUBYF5bYtZ2X2zE0fR75h0KNKIPapF/RoR+gz4=; c=relaxed/relaxed; d=dujemihanovic.xyz; h=Subject:Subject:Sender:To:To:Cc:Cc:From:From:Date:Date:MIME-Version:MIME-Version:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Reply-To:In-Reply-To:In-Reply-To:Message-Id:Message-Id:References:References:Autocrypt:Openpgp; i=@dujemihanovic.xyz; s=default; t=1756559233; v=1; x=1756991233; b=OOZeaIUxy1iac2ViPetI3Fw61UM5lvo0hMes5dn5vkB+jOsDp2WQ1yXCvPYKl7m7F6160I97 MbSnm254g8KAbzt6AvaAEZK1UgrLl5sAJP06SdGuvsZWdRwe//nwYPBAhZBge9axUuX0cf8vWJp CHobMys6sBXg2iEpzzO/DMeSjDRlxjRqdDA4Db4N+ug02c+KZT7kZwljoR5o7mFGBDRr5byhrTv vlHpk8CCzGVrvRYTJHxSPTnbEDDWn3WfxsFZAsxLUZ/Z09LmrGNPYCtVcEQRo2tyHt9iqI/Nzth 0q6rB+eY8Vw/ExrnyGTYw8dar2nKpb6/Bu7p/BTrEVY8w== Received: by mx.olsak.net (envelope-sender ) with ESMTPS id 55baaa3f; Sat, 30 Aug 2025 15:07:13 +0200 From: Duje =?UTF-8?B?TWloYW5vdmnEhw==?= To: David Lechner , Andy Shevchenko Cc: Jonathan Cameron , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Karel Balej , Lee Jones , David Wronek , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC Date: Sat, 30 Aug 2025 15:07:12 +0200 Message-ID: <22825864.EfDdHjke4D@radijator> In-Reply-To: References: <20250829-88pm886-gpadc-v1-0-f60262266fea@dujemihanovic.xyz> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Saturday, 30 August 2025 06:41:58 Central European Summer Time Andy=20 Shevchenko wrote: > On Sat, Aug 30, 2025 at 7:37=E2=80=AFAM Andy Shevchenko >=20 > wrote: > > On Fri, Aug 29, 2025 at 2:41=E2=80=AFAM David Lechner =20 wrote: > > > On 8/28/25 5:17 PM, Duje Mihanovi=C4=87 wrote: > ... >=20 > > > > + ret =3D regmap_bulk_read(*map, regs[chan], buf, 2); >=20 > On top, please drop a double pointer and use map directly. That's > already a pointer, what's the issue with it to begin with? struct regmap is only defined in a regmap-internal header, so it has to be a double pointer or a struct containing a regmap pointer. I went with David's advice and created this struct. Regards, =2D- Duje