From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 804F2EB64D8 for ; Tue, 13 Jun 2023 18:42:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232005AbjFMSmK (ORCPT ); Tue, 13 Jun 2023 14:42:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232141AbjFMSmH (ORCPT ); Tue, 13 Jun 2023 14:42:07 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A00BCAD for ; Tue, 13 Jun 2023 11:42:05 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5147e8972a1so10051843a12.0 for ; Tue, 13 Jun 2023 11:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686681724; x=1689273724; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E9J/4CK07txoWvpRkuIct5M/3DR+A6hR9YqitxGo9vo=; b=xHwJevKZzycIwLN/4ZqriOCeYi5DJ96nxJzDAAZ0N+jJnd0V8WmUNr1RxOMEoPvxX5 09gskRLCGdXoN7u+104ZDtC4DDYiAEuSSs872rlQ378IODj4EVgWt2E/TRwO+JtHxWo7 ZXWfdEcvIcEO9yfqWr2CyFnXkIsbCe35lgFDe+te0ybeiw/zDv3o7MUGybqRjTGZoOSI 5gPVdO2zDfg/WHFWksLTpUkHgxD9zgziIFzZaL/6awMT8kqkFKO/7NWOg/mGF4FuYW5b pSkCTLzmmwX46aPrAlddBGryxTYcHXZZGJtcQ1ZTOVzCG2AJEfmeg5/Hox4XK3XrGe+y vHpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686681724; x=1689273724; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E9J/4CK07txoWvpRkuIct5M/3DR+A6hR9YqitxGo9vo=; b=ESk7AUx6+oLlTFMd2LyXzjoCx0jj1SfyyQDX7/S4UfM6XEDup5d7tP3iosv1eRnLMA 9Cdfe7IQZsSbJB51SWaVe2b12iweVBY+79lWiZN9AZ3eptJISIBsq0yQDuIlugoZJN96 26S7toEfd5jYnhdt4p+DqpYKEm1Ik6DcW8REI9x2G66ivZkDe1QXpM4VjhYs8WF3ZUGb uCptZwMPqXU+WDC36jikUq0cG17dFc2I1irpw6P4Ba4GHcaMH9eSkNayC9sNyw1hGV8q 4ymtxGMyQ01a4+A4bROYi8j5N24BeMetvrGZN2RXnL3uCDRueXs4ei9gyneh04ZHYUCq RF9g== X-Gm-Message-State: AC+VfDwoDgQL2OEayiVdgQb2m3MPPO9mBxO6ENWGuzK4h7zztNufvo0J 1g3ZqeiXtMa4ZI/XHZxl14c2UA== X-Google-Smtp-Source: ACHHUZ4f5uJfXxJ457q4UknWNqD0gfSHRZjl8xS4OTPNrTEg99TpXgpzNXgzXCMlipTdb7eHArGrXQ== X-Received: by 2002:a17:907:807:b0:977:d027:eeb9 with SMTP id wv7-20020a170907080700b00977d027eeb9mr12854684ejb.35.1686681724047; Tue, 13 Jun 2023 11:42:04 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id n24-20020a170906379800b0096a6bf89259sm6961056ejc.167.2023.06.13.11.42.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 11:42:03 -0700 (PDT) Message-ID: <22dadcf6-9879-efb2-9987-7f286b38b93b@linaro.org> Date: Tue, 13 Jun 2023 20:42:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/3] dt-bindings: ROHM BU27010 RGBC + flickering sensor Content-Language: en-US To: Matti Vaittinen , Matti Vaittinen Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <98e0b6fba7ff7515b541a517296d5b89dc73ce5b.1686651445.git.mazziesaccount@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <98e0b6fba7ff7515b541a517296d5b89dc73ce5b.1686651445.git.mazziesaccount@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 13/06/2023 12:19, Matti Vaittinen wrote: > The ROHM BU27010 is a sensor with 6 photodiodes (red, green, blue, clear, > IR and flickering detection) with five configurable channels. Red, green > and flickering detection being always available and two out of the rest > three (blue, clear, IR) can be selected to be simultaneously measured. > Typical application is adjusting LCD/OLED backlight of TVs, mobile phones > and tablet PCs. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. e.g.: "dt-bindings: iio:" > > Add binding document for ROHM BU27010. > > Signed-off-by: Matti Vaittinen > --- > .../bindings/iio/light/rohm,bu27010.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml > > diff --git a/Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml b/Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml > new file mode 100644 > index 000000000000..2bde9d2f1def > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/light/rohm,bu27010.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ROHM BU27010 color sensor > + > +maintainers: > + - Matti Vaittinen > + > +description: | > + The ROHM BU27010 is a sensor with 6 photodiodes (red, green, blue, clear, > + IR and flickering detection) with five configurable channels. Red, green > + and flickering detection being always available and two out of the rest > + three (blue, clear, IR) can be selected to be simultaneously measured. > + Typical application is adjusting LCD/OLED backlight of TVs, mobile phones > + and tablet PCs. > + > +properties: > + compatible: > + const: rohm,bu27010 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vdd-supply: true Isn't vdd-supply required for the hardware to work? How does it get the power otherwise? > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + light-sensor@38 { > + compatible = "rohm,bu27010"; > + reg = <0x38>; > + }; > + }; > + Trailing blank line. Best regards, Krzysztof