From: Heiko Stuebner <heiko@sntech.de>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108
Date: Sun, 13 Aug 2017 14:13:01 +0200 [thread overview]
Message-ID: <2309743.33rDFhBfGp@phil> (raw)
In-Reply-To: <1502423211-31216-1-git-send-email-andy.yan@rock-chips.com>
Hi Andy,
Am Freitag, 11. August 2017, 11:46:51 CEST schrieb Andy Yan:
> Add saradc device tree node for rv1108 soc
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
> + adc: adc@1038c000 {
> + compatible = "rockchip,rv1108-saradc", "rockchip,rk3399-saradc";
> + reg = <0x1038c000 0x100>;
> + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
What do you need the io-channel-ranges for?
I.e. according to the documenation it is meant for when the adc is also
a "bus node" and has children that should inherit channels from it.
In all saradc uses so far we only have separate nodes referencing the
adc controller (like adc-keys etc), so this does not look like it is needed?
Heiko
next prev parent reply other threads:[~2017-08-13 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 3:36 [PATCH v3 00/13] Support more devices on rockchip rv1108 Andy Yan
2017-08-11 3:46 ` [PATCH v3 09/13] dt-bindings: adc: add description for rv1108 saradc Andy Yan
2017-08-12 12:39 ` Jonathan Cameron
2017-08-11 3:46 ` [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108 Andy Yan
2017-08-13 12:13 ` Heiko Stuebner [this message]
2017-08-14 1:42 ` Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2309743.33rDFhBfGp@phil \
--to=heiko@sntech.de \
--cc=andy.yan@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).