Re: [PATCH] iio: ti-adc128s052: Drop variable vref

[Matti Vaittinen <mazziesaccount@gmail.com>]

On 28/04/2025 18:16, David Lechner wrote:
> On 4/28/25 2:02 AM, Matti Vaittinen wrote:
>> According to Jonathan, variable reference voltages are very rare. It is
>> unlikely it is needed, and supporting it makes the code a bit more
>> complex.
>>
>> Simplify the driver and drop the variable vref support.
>>
>> Suggested-by: Jonathan Cameron <jic23@kernel.org>
>> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
>>
>> ---
> 
> Reviewed-by: David Lechner <dlechner@baylibre.com>
> 
>> @@ -183,17 +173,14 @@ static int adc128_probe(struct spi_device *spi)
>>   	indio_dev->channels = config->channels;
>>   	indio_dev->num_channels = config->num_channels;
>>   
>> -	adc->reg = devm_regulator_get(&spi->dev, config->refname);
>> -	if (IS_ERR(adc->reg))
>> -		return PTR_ERR(adc->reg);
>> -
>> -	ret = regulator_enable(adc->reg);
>> +	ret = devm_regulator_get_enable_read_voltage(&spi->dev,
>> +							   config->refname);
> 
> Is this properly aligned to the opening "("?

Thanks David. No, it's off by one tab. Nicely spotted :)

Yours,
	-- Matti