From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Li peiyu <579lpy@gmail.com>, jic23@kernel.org
Cc: javier.carrasco.cruz@gmail.com, lars@metafoo.de,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 4/4] dt-bindings: iio: humidity: Add TI HDC302x support
Date: Sat, 9 Dec 2023 12:49:45 +0100 [thread overview]
Message-ID: <261094ae-b14e-464f-9d01-87a2bbcb40e0@linaro.org> (raw)
In-Reply-To: <20231209105926.3965-1-579lpy@gmail.com>
On 09/12/2023 11:59, Li peiyu wrote:
> Add device tree bindings for HDC3020/HDC3021/HDC3022 humidity and
> temperature sensors.
>
> Signed-off-by: Li peiyu <579lpy@gmail.com>
> ---
> .../bindings/iio/humidity/ti,hdc3020.yaml | 55 +++++++++++++++++++
> 1 file changed, 55 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
> new file mode 100644
> index 000000000000..f04b09fdca5e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/humidity/ti,hdc3020.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HDC3020/HDC3021/HDC3022 humidity and temperature iio sensors
> +
> +maintainers:
> + - Li peiyu <579lpy@gmail.com>
> + - Javier Carrasco <javier.carrasco.cruz@gmail.com>
> +
> +description:
> + https://www.ti.com/lit/ds/symlink/hdc3020.pdf
> +
> + The HDC302x is an integrated capacitive based relative humidity (RH)
> + and temperature sensor.
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - ti,hdc3021
> + - ti,hdc3022
> + - const: ti,hdc3020
> + - items:
> + - const: ti,hdc3020
Three of my comments were ignored. Also Conor's tag.
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-09 11:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 10:52 [PATCH v5 0/4] iio: humidity: Add driver for ti HDC302x humidity sensors Li peiyu
2023-12-09 10:54 ` [PATCH v5 1/4] iio: core: introduce trough info element for minimum values Li peiyu
2023-12-09 10:56 ` [PATCH v5 2/4] iio: ABI: document temperature and humidity peak/trough raw attributes Li peiyu
2023-12-09 10:58 ` [PATCH v5 3/4] iio: humidity: Add driver for ti HDC302x humidity sensors Li peiyu
2023-12-10 14:17 ` Jonathan Cameron
2023-12-09 10:59 ` [PATCH v5 4/4] dt-bindings: iio: humidity: Add TI HDC302x support Li peiyu
2023-12-09 11:49 ` Krzysztof Kozlowski [this message]
2023-12-09 20:29 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=261094ae-b14e-464f-9d01-87a2bbcb40e0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=579lpy@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox