* [PATCH] iio: pressure: bmp280: fix datasheet links
@ 2022-08-15 23:38 Angel Iglesias
2022-08-19 9:37 ` Andy Shevchenko
0 siblings, 1 reply; 8+ messages in thread
From: Angel Iglesias @ 2022-08-15 23:38 UTC (permalink / raw)
To: linux-iio
Cc: Angel Iglesias, Andy Shevchenko, Jonathan Cameron,
Lars-Peter Clausen, Rafael J. Wysocki, Paul Cercueil, Ulf Hansson,
linux-kernel
Updated links for BMP280 and BME280 datasheets on Bosch website.
Datasheet of BMP180 is no longer available on the manufacturer's website,
changed the link to a copy hosted by a third party.
Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
---
drivers/iio/pressure/bmp280-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
index fe7aa81e7cc9..e98b024d510b 100644
--- a/drivers/iio/pressure/bmp280-core.c
+++ b/drivers/iio/pressure/bmp280-core.c
@@ -9,9 +9,9 @@
* Driver for Bosch Sensortec BMP180 and BMP280 digital pressure sensor.
*
* Datasheet:
- * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
- * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
- * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
+ * https://cdn-shop.adafruit.com/datasheets/BST-BMP180-DS000-09.pdf
+ * https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp280-ds001.pdf
+ * https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bme280-ds002.pdf
*/
#define pr_fmt(fmt) "bmp280: " fmt
base-commit: b82217e73b5aa6db8453ad91b929ca2366e47184
--
2.37.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] iio: pressure: bmp280: fix datasheet links
2022-08-15 23:38 [PATCH] iio: pressure: bmp280: fix datasheet links Angel Iglesias
@ 2022-08-19 9:37 ` Andy Shevchenko
2022-08-19 10:31 ` Angel Iglesias
0 siblings, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2022-08-19 9:37 UTC (permalink / raw)
To: Angel Iglesias
Cc: linux-iio, Jonathan Cameron, Lars-Peter Clausen,
Rafael J. Wysocki, Paul Cercueil, Ulf Hansson,
Linux Kernel Mailing List
On Tue, Aug 16, 2022 at 2:39 AM Angel Iglesias <ang.iglesiasg@gmail.com> wrote:
>
> Updated links for BMP280 and BME280 datasheets on Bosch website.
> Datasheet of BMP180 is no longer available on the manufacturer's website,
> changed the link to a copy hosted by a third party.
Note, that the version is downgraded (from 12.1 to 9).
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> ---
> drivers/iio/pressure/bmp280-core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
> index fe7aa81e7cc9..e98b024d510b 100644
> --- a/drivers/iio/pressure/bmp280-core.c
> +++ b/drivers/iio/pressure/bmp280-core.c
> @@ -9,9 +9,9 @@
> * Driver for Bosch Sensortec BMP180 and BMP280 digital pressure sensor.
> *
> * Datasheet:
> - * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
> - * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
> - * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
> + * https://cdn-shop.adafruit.com/datasheets/BST-BMP180-DS000-09.pdf
> + * https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp280-ds001.pdf
> + * https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bme280-ds002.pdf
> */
>
> #define pr_fmt(fmt) "bmp280: " fmt
>
> base-commit: b82217e73b5aa6db8453ad91b929ca2366e47184
> --
> 2.37.2
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iio: pressure: bmp280: fix datasheet links
2022-08-19 9:37 ` Andy Shevchenko
@ 2022-08-19 10:31 ` Angel Iglesias
2022-08-19 10:33 ` Andy Shevchenko
0 siblings, 1 reply; 8+ messages in thread
From: Angel Iglesias @ 2022-08-19 10:31 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-iio, Jonathan Cameron, Lars-Peter Clausen,
Rafael J. Wysocki, Paul Cercueil, Ulf Hansson,
Linux Kernel Mailing List
On Fri, 2022-08-19 at 12:37 +0300, Andy Shevchenko wrote:
> On Tue, Aug 16, 2022 at 2:39 AM Angel Iglesias <ang.iglesiasg@gmail.com>
> wrote:
> >
> > Updated links for BMP280 and BME280 datasheets on Bosch website.
>
> > Datasheet of BMP180 is no longer available on the manufacturer's website,
> > changed the link to a copy hosted by a third party.
>
> Note, that the version is downgraded (from 12.1 to 9).
Apologies, I forgot to add a note about this. Changelog on datasheet 12.1 listed
these three changes from version 9:
* Page 26: Changed document referral from ANP015 to BST-MPS-AN004-00
* Chapter 3.5: New equation for B3 (adds a long cast to AC1)
* Page 26: Updated RoHS directive to 2011/65/EU effective 8 June 2011
Unfortunately, I couldn't find the most updated version in good quality hosted
in a trustworthy place.
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> > Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> > ---
> > drivers/iio/pressure/bmp280-core.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/pressure/bmp280-core.c
> > b/drivers/iio/pressure/bmp280-core.c
> > index fe7aa81e7cc9..e98b024d510b 100644
> > --- a/drivers/iio/pressure/bmp280-core.c
> > +++ b/drivers/iio/pressure/bmp280-core.c
> > @@ -9,9 +9,9 @@
> > * Driver for Bosch Sensortec BMP180 and BMP280 digital pressure sensor.
> > *
> > * Datasheet:
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
> > + * https://cdn-shop.adafruit.com/datasheets/BST-BMP180-DS000-09.pdf
> > + *
> > https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp280-ds001.pdf
> > + *
> > https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bme280-ds002.pdf
> > */
> >
> > #define pr_fmt(fmt) "bmp280: " fmt
> >
> > base-commit: b82217e73b5aa6db8453ad91b929ca2366e47184
> > --
> > 2.37.2
> >
>
>
Kind regards,
Angel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iio: pressure: bmp280: fix datasheet links
2022-08-19 10:31 ` Angel Iglesias
@ 2022-08-19 10:33 ` Andy Shevchenko
2022-08-19 11:09 ` Angel Iglesias
2022-09-12 22:26 ` [PATCH v2] " Angel Iglesias
0 siblings, 2 replies; 8+ messages in thread
From: Andy Shevchenko @ 2022-08-19 10:33 UTC (permalink / raw)
To: Angel Iglesias
Cc: linux-iio, Jonathan Cameron, Lars-Peter Clausen,
Rafael J. Wysocki, Paul Cercueil, Ulf Hansson,
Linux Kernel Mailing List
On Fri, Aug 19, 2022 at 1:31 PM Angel Iglesias <ang.iglesiasg@gmail.com> wrote:
> On Fri, 2022-08-19 at 12:37 +0300, Andy Shevchenko wrote:
> > On Tue, Aug 16, 2022 at 2:39 AM Angel Iglesias <ang.iglesiasg@gmail.com>
> > wrote:
> > >
> > > Updated links for BMP280 and BME280 datasheets on Bosch website.
> >
> > > Datasheet of BMP180 is no longer available on the manufacturer's website,
> > > changed the link to a copy hosted by a third party.
> >
> > Note, that the version is downgraded (from 12.1 to 9).
>
> Apologies, I forgot to add a note about this. Changelog on datasheet 12.1 listed
> these three changes from version 9:
> * Page 26: Changed document referral from ANP015 to BST-MPS-AN004-00
> * Chapter 3.5: New equation for B3 (adds a long cast to AC1)
> * Page 26: Updated RoHS directive to 2011/65/EU effective 8 June 2011
Perhaps you may add this to the comment below into the code.
> Unfortunately, I couldn't find the most updated version in good quality hosted
> in a trustworthy place.
Me neither.
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iio: pressure: bmp280: fix datasheet links
2022-08-19 10:33 ` Andy Shevchenko
@ 2022-08-19 11:09 ` Angel Iglesias
2022-09-12 22:26 ` [PATCH v2] " Angel Iglesias
1 sibling, 0 replies; 8+ messages in thread
From: Angel Iglesias @ 2022-08-19 11:09 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-iio, Jonathan Cameron, Lars-Peter Clausen,
Rafael J. Wysocki, Paul Cercueil, Ulf Hansson,
Linux Kernel Mailing List
On Fri, 2022-08-19 at 13:33 +0300, Andy Shevchenko wrote:
> On Fri, Aug 19, 2022 at 1:31 PM Angel Iglesias <ang.iglesiasg@gmail.com>
> wrote:
> > On Fri, 2022-08-19 at 12:37 +0300, Andy Shevchenko wrote:
> > > On Tue, Aug 16, 2022 at 2:39 AM Angel Iglesias <ang.iglesiasg@gmail.com>
> > > wrote:
> > > >
> > > > Updated links for BMP280 and BME280 datasheets on Bosch website.
> > >
> > > > Datasheet of BMP180 is no longer available on the manufacturer's
> > > > website,
> > > > changed the link to a copy hosted by a third party.
> > >
> > > Note, that the version is downgraded (from 12.1 to 9).
> >
> > Apologies, I forgot to add a note about this. Changelog on datasheet 12.1
> > listed
> > these three changes from version 9:
> > * Page 26: Changed document referral from ANP015 to BST-MPS-AN004-00
> > * Chapter 3.5: New equation for B3 (adds a long cast to AC1)
> > * Page 26: Updated RoHS directive to 2011/65/EU effective 8 June 2011
>
> Perhaps you may add this to the comment below into the code.
Will do, thanks
>
> > Unfortunately, I couldn't find the most updated version in good quality
> > hosted
> > in a trustworthy place.
>
> Me neither.
>
> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
Kind regards,
Angel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] iio: pressure: bmp280: fix datasheet links
2022-08-19 10:33 ` Andy Shevchenko
2022-08-19 11:09 ` Angel Iglesias
@ 2022-09-12 22:26 ` Angel Iglesias
2022-09-15 13:39 ` Jonathan Cameron
1 sibling, 1 reply; 8+ messages in thread
From: Angel Iglesias @ 2022-09-12 22:26 UTC (permalink / raw)
To: linux-iio
Cc: Angel Iglesias, Andy Shevchenko, Jonathan Cameron,
Lars-Peter Clausen, Paul Cercueil, Rafael J. Wysocki, Ulf Hansson,
linux-kernel
Updated links for BMP280 and BME280 datasheets on Bosch website.
Datasheet of BMP180 is no longer available on the manufacturer's website,
changed the link to a copy hosted by a third party.
Changelog in v2:
* Added a notice about the situation with bmp180 datasheet and list
missing changes from newer versions.
Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
---
drivers/iio/pressure/bmp280-core.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
index fe7aa81e7cc9..01cd32003ca8 100644
--- a/drivers/iio/pressure/bmp280-core.c
+++ b/drivers/iio/pressure/bmp280-core.c
@@ -9,9 +9,15 @@
* Driver for Bosch Sensortec BMP180 and BMP280 digital pressure sensor.
*
* Datasheet:
- * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
- * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
- * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
+ * https://cdn-shop.adafruit.com/datasheets/BST-BMP180-DS000-09.pdf
+ * https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp280-ds001.pdf
+ * https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bme280-ds002.pdf
+ *
+ * Notice:
+ * The link to the bmp180 datasheet points to an outdated version missing these changes:
+ * - Changed document referral from ANP015 to BST-MPS-AN004-00 on page 26
+ * - Updated equation for B3 param on section 3.5 to ((((long)AC1 * 4 + X3) << oss) + 2) / 4
+ * - Updated RoHS directive to 2011/65/EU effective 8 June 2011 on page 26
*/
#define pr_fmt(fmt) "bmp280: " fmt
base-commit: 2f61ff8272967c9bdcba810aa978170814b08f7c
--
2.37.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] iio: pressure: bmp280: fix datasheet links
2022-09-12 22:26 ` [PATCH v2] " Angel Iglesias
@ 2022-09-15 13:39 ` Jonathan Cameron
2022-09-15 14:59 ` Angel Iglesias
0 siblings, 1 reply; 8+ messages in thread
From: Jonathan Cameron @ 2022-09-15 13:39 UTC (permalink / raw)
To: Angel Iglesias
Cc: linux-iio, Andy Shevchenko, Lars-Peter Clausen, Paul Cercueil,
Rafael J. Wysocki, Ulf Hansson, linux-kernel
On Tue, 13 Sep 2022 00:26:44 +0200
Angel Iglesias <ang.iglesiasg@gmail.com> wrote:
> Updated links for BMP280 and BME280 datasheets on Bosch website.
> Datasheet of BMP180 is no longer available on the manufacturer's website,
> changed the link to a copy hosted by a third party.
>
> Changelog in v2:
> * Added a notice about the situation with bmp180 datasheet and list
> missing changes from newer versions.
Change log needs to be below the ---
We don't want that level of detail in the git logs.
I tidied that up whilst applying.
Also, it's not a good idea to have new versions as replies
to older ones. Leads to very deep nesting in email threads
and generally makes things less readable. Just post
a fresh series each time.
Applied to the togreg branch of iio.git and pushed out as testing
for 0-day to see if it can find anything (rather unlikely on this
patch!)
Jonathan
>
> Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> ---
> drivers/iio/pressure/bmp280-core.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
> index fe7aa81e7cc9..01cd32003ca8 100644
> --- a/drivers/iio/pressure/bmp280-core.c
> +++ b/drivers/iio/pressure/bmp280-core.c
> @@ -9,9 +9,15 @@
> * Driver for Bosch Sensortec BMP180 and BMP280 digital pressure sensor.
> *
> * Datasheet:
> - * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
> - * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
> - * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
> + * https://cdn-shop.adafruit.com/datasheets/BST-BMP180-DS000-09.pdf
> + * https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp280-ds001.pdf
> + * https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bme280-ds002.pdf
> + *
> + * Notice:
> + * The link to the bmp180 datasheet points to an outdated version missing these changes:
> + * - Changed document referral from ANP015 to BST-MPS-AN004-00 on page 26
> + * - Updated equation for B3 param on section 3.5 to ((((long)AC1 * 4 + X3) << oss) + 2) / 4
> + * - Updated RoHS directive to 2011/65/EU effective 8 June 2011 on page 26
> */
>
> #define pr_fmt(fmt) "bmp280: " fmt
>
> base-commit: 2f61ff8272967c9bdcba810aa978170814b08f7c
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] iio: pressure: bmp280: fix datasheet links
2022-09-15 13:39 ` Jonathan Cameron
@ 2022-09-15 14:59 ` Angel Iglesias
0 siblings, 0 replies; 8+ messages in thread
From: Angel Iglesias @ 2022-09-15 14:59 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-iio, Andy Shevchenko, Lars-Peter Clausen, Paul Cercueil,
Rafael J. Wysocki, Ulf Hansson, linux-kernel
On jue, 2022-09-15 at 14:39 +0100, Jonathan Cameron wrote:
> On Tue, 13 Sep 2022 00:26:44 +0200
> Angel Iglesias <ang.iglesiasg@gmail.com> wrote:
>
> > Updated links for BMP280 and BME280 datasheets on Bosch website.
> > Datasheet of BMP180 is no longer available on the manufacturer's website,
> > changed the link to a copy hosted by a third party.
> >
> > Changelog in v2:
> > * Added a notice about the situation with bmp180 datasheet and list
> > missing changes from newer versions.
> Change log needs to be below the ---
>
> We don't want that level of detail in the git logs.
>
> I tidied that up whilst applying.
>
> Also, it's not a good idea to have new versions as replies
> to older ones. Leads to very deep nesting in email threads
> and generally makes things less readable. Just post
> a fresh series each time.
>
> Applied to the togreg branch of iio.git and pushed out as testing
> for 0-day to see if it can find anything (rather unlikely on this
> patch!)
>
> Jonathan
>
OK, I'll keep it on my mind for future contributions. Thanks for your help and
patience!
Kind regards,
Angel
>
> >
> > Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> > ---
> > drivers/iio/pressure/bmp280-core.c | 12 +++++++++---
> > 1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/pressure/bmp280-core.c
> > b/drivers/iio/pressure/bmp280-core.c
> > index fe7aa81e7cc9..01cd32003ca8 100644
> > --- a/drivers/iio/pressure/bmp280-core.c
> > +++ b/drivers/iio/pressure/bmp280-core.c
> > @@ -9,9 +9,15 @@
> > * Driver for Bosch Sensortec BMP180 and BMP280 digital pressure sensor.
> > *
> > * Datasheet:
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
> > + * https://cdn-shop.adafruit.com/datasheets/BST-BMP180-DS000-09.pdf
> > + *
> > https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp280-ds001.pdf
> > + *
> > https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bme280-ds002.pdf
> > + *
> > + * Notice:
> > + * The link to the bmp180 datasheet points to an outdated version missing
> > these changes:
> > + * - Changed document referral from ANP015 to BST-MPS-AN004-00 on page 26
> > + * - Updated equation for B3 param on section 3.5 to ((((long)AC1 * 4 + X3)
> > << oss) + 2) / 4
> > + * - Updated RoHS directive to 2011/65/EU effective 8 June 2011 on page 26
> > */
> >
> > #define pr_fmt(fmt) "bmp280: " fmt
> >
> > base-commit: 2f61ff8272967c9bdcba810aa978170814b08f7c
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-09-15 15:00 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-15 23:38 [PATCH] iio: pressure: bmp280: fix datasheet links Angel Iglesias
2022-08-19 9:37 ` Andy Shevchenko
2022-08-19 10:31 ` Angel Iglesias
2022-08-19 10:33 ` Andy Shevchenko
2022-08-19 11:09 ` Angel Iglesias
2022-09-12 22:26 ` [PATCH v2] " Angel Iglesias
2022-09-15 13:39 ` Jonathan Cameron
2022-09-15 14:59 ` Angel Iglesias
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).